Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: remoting/protocol/datagram_channel_factory.h

Issue 551173004: Move PseudoTCP and channel auth out of LibjingleTransportFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clean_dgrams
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/datagram_channel_factory.h
diff --git a/remoting/protocol/datagram_channel_factory.h b/remoting/protocol/datagram_channel_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..1f687516385d90c1bbb962e787572085ed5c1592
--- /dev/null
+++ b/remoting/protocol/datagram_channel_factory.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_
+#define REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_
+
+namespace net {
+class Socket;
+} // namespace net
+
+namespace remoting {
+namespace protocol {
+
+class DatagramChannelFactory {
+ public:
+ typedef base::Callback<void(scoped_ptr<net::Socket>)>
+ ChannelCreatedCallback;
+
+ DatagramChannelFactory() {}
+
+ // Creates new channels and calls the |callback| when then new channel is
+ // created and connected. The |callback| is called with NULL if connection
+ // failed for any reason. Callback may be called synchronously, before the
Wez 2014/09/10 02:29:26 nit: There is no "connection" for a datagram chann
Sergey Ulanov 2014/09/10 21:50:58 There might be in some cases. E.g. for secure DTLS
Wez 2014/09/10 22:19:41 True; maybe refer to it as "channel setup" rather
Sergey Ulanov 2014/09/10 22:49:30 Done.
+ // call returns. All channels must be destroyed before the factory is
+ // destroyed and CancelChannelCreation() must be called to cancel creation of
+ // channels for which the |callback| hasn't been called yet.
Wez 2014/09/10 02:29:26 See comments on ChannelFactory
Sergey Ulanov 2014/09/10 21:50:58 Done.
+ virtual void CreateChannel(const std::string& name,
+ const ChannelCreatedCallback& callback) = 0;
+
+ // Cancels a pending CreateChannel() operation for the named channel. If the
+ // channel creation already completed then canceling it has no effect. When
+ // shutting down this method must be called for each channel pending creation.
+ virtual void CancelChannelCreation(const std::string& name) = 0;
+
+ protected:
+ virtual ~DatagramChannelFactory() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DatagramChannelFactory);
+};
+
+} // namespace protocol
+} // namespace remoting
+
+#endif // REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698