Move PseudoTCP and channel auth out of LibjingleTransportFactory.

remoting/protocol/datagram_channel_factory.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_
+#define REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_
+
+namespace net {
+class Socket;
+}  // namespace net
+
+namespace remoting {
+namespace protocol {
+
+class DatagramChannelFactory {
+ public:
+  typedef base::Callback<void(scoped_ptr<net::Socket>)>
+      ChannelCreatedCallback;
+
+  DatagramChannelFactory() {}
+
+  // Creates new channels and calls the |callback| when then new channel is
+  // created and connected. The |callback| is called with NULL if connection
+  // failed for any reason. Callback may be called synchronously, before the

[Wez, 2014/09/10 02:29:26]

nit: There is no "connection" for a datagram channel, though.

[Sergey Ulanov, 2014/09/10 21:50:58]

There might be in some cases. E.g. for secure DTLS channel we would want to
finish DTLS handshake before returning it, which may fail.

[Wez, 2014/09/10 22:19:41]

True; maybe refer to it as "channel setup" rather than "connection"? Up to you,
though.

[Sergey Ulanov, 2014/09/10 22:49:30]

Done.

+  // call returns. All channels must be destroyed before the factory is
+  // destroyed and CancelChannelCreation() must be called to cancel creation of
+  // channels for which the |callback| hasn't been called yet.

[Wez, 2014/09/10 02:29:26]

See comments on ChannelFactory

[Sergey Ulanov, 2014/09/10 21:50:58]

Done.

+  virtual void CreateChannel(const std::string& name,
+                             const ChannelCreatedCallback& callback) = 0;
+
+  // Cancels a pending CreateChannel() operation for the named channel. If the
+  // channel creation already completed then canceling it has no effect. When
+  // shutting down this method must be called for each channel pending creation.
+  virtual void CancelChannelCreation(const std::string& name) = 0;
+
+ protected:
+  virtual ~DatagramChannelFactory() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DatagramChannelFactory);
+};
+
+}  // namespace protocol
+}  // namespace remoting
+
+#endif  // REMOTING_PROTOCOL_DATAGRAM_CHANNEL_FACTORY_H_