Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 551073003: Revert of Adding Select Action Bar Unit test case for input (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Select Action Bar Unit test case for input (patchset #3 id:40001 of https://codereview.chromium.org/506423003/) Reason for revert: This test fails on Android Tests (dbg) C 850.137s Main [FAIL] org.chromium.content.browser.input.ImeTest#testSelectActionBarClearedOnTappingInput: C 850.137s Main junit.framework.AssertionFailedError C 850.137s Main at org.chromium.content.browser.input.ImeTest.assertWaitForSelectActionBarStatus(ImeTest.java:698) C 850.137s Main at org.chromium.content.browser.input.ImeTest.testSelectActionBarClearedOnTappingInput(ImeTest.java:206) C 850.137s Main at java.lang.reflect.Method.invokeNative(Native Method) C 850.137s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 850.137s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 850.137s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 850.137s Main at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227) C 850.137s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 850.137s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 850.137s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 850.137s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) Original issue's description: > [Android] Add unit tests for SelectActionBar appearance > > The SelectActionBar currently lacks test coverage. Add several test > cases covering the appearance of the bar when interacting with an input > field. > > Committed: https://chromium.googlesource.com/chromium/src/+/0bc56569817a24acea46748c599d77b59157d84d TBR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
Created Revert of Adding Select Action Bar Unit test case for input
6 years, 3 months ago (2014-09-08 18:44:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/551073003/1
6 years, 3 months ago (2014-09-08 18:48:46 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-08 18:51:10 UTC) #4
arv (Not doing code reviews)
On 2014/09/08 18:51:10, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 3 months ago (2014-09-08 18:58:39 UTC) #5
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-08 19:09:28 UTC) #6
On 2014/09/08 18:58:39, arv wrote:
> On 2014/09/08 18:51:10, I haz the power (commit-bot) wrote:
> > Failed to apply patch for
> 
> I'll disable the test instead.

https://codereview.chromium.org/553833003/

Powered by Google App Engine
This is Rietveld 408576698