Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 550943002: Remove unneeded constructor for CompositionUnderline (Closed)

Created:
6 years, 3 months ago by rtakacs
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unneeded constructor for CompositionUnderline Removed an unused CompositionUnderline constructor. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/core/editing/CompositionUnderline.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rtakacs
6 years, 3 months ago (2014-09-08 17:29:49 UTC) #1
rtakacs
6 years, 3 months ago (2014-09-09 15:09:33 UTC) #3
Julien - ping for review
lgtm (ideally some editing folks should confirm the plans didn't change).
6 years, 3 months ago (2014-09-09 19:52:22 UTC) #5
Julien - ping for review
On 2014/09/09 at 19:52:22, Julien Chaffraix - PST wrote: > lgtm (ideally some editing folks ...
6 years, 3 months ago (2014-09-09 19:52:49 UTC) #6
huangs
LGTM, thanks for taking care of this!
6 years, 3 months ago (2014-09-09 21:05:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/550943002/1
6 years, 3 months ago (2014-09-09 21:42:47 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 22:33:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181682

Powered by Google App Engine
This is Rietveld 408576698