Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/core/editing/CompositionUnderline.h

Issue 550943002: Remove unneeded constructor for CompositionUnderline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 namespace blink { 31 namespace blink {
32 32
33 struct CompositionUnderline { 33 struct CompositionUnderline {
34 CompositionUnderline() 34 CompositionUnderline()
35 : startOffset(0) 35 : startOffset(0)
36 , endOffset(0) 36 , endOffset(0)
37 , color(Color::transparent) 37 , color(Color::transparent)
38 , thick(false) 38 , thick(false)
39 , backgroundColor(Color::transparent) { } 39 , backgroundColor(Color::transparent) { }
40 40
41 // FIXME(huangs): remove this constructor.
42 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t)
43 : startOffset(s)
44 , endOffset(e)
45 , color(c)
46 , thick(t)
47 , backgroundColor(Color::transparent) { }
48
49 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t, const C olor& bc) 41 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t, const C olor& bc)
50 : startOffset(s) 42 : startOffset(s)
51 , endOffset(e) 43 , endOffset(e)
52 , color(c) 44 , color(c)
53 , thick(t) 45 , thick(t)
54 , backgroundColor(bc) { } 46 , backgroundColor(bc) { }
55 47
56 unsigned startOffset; 48 unsigned startOffset;
57 unsigned endOffset; 49 unsigned endOffset;
58 Color color; 50 Color color;
59 bool thick; 51 bool thick;
60 Color backgroundColor; 52 Color backgroundColor;
61 }; 53 };
62 54
63 } // namespace blink 55 } // namespace blink
64 56
65 #endif // CompositionUnderline_h 57 #endif // CompositionUnderline_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698