Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.h

Issue 550543003: Add Instrumental Test for BookmarksBridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/bookmarks_bridge.h
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.h b/chrome/browser/android/bookmarks/bookmarks_bridge.h
index 84a3e9bf1e98e227cebe4ca34b5390fe66ac81f9..e5365a397741f1ea75837e14703ee77aa3083919 100644
--- a/chrome/browser/android/bookmarks/bookmarks_bridge.h
+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.h
@@ -23,6 +23,7 @@ class Profile;
// hierarchy.
class BookmarksBridge : public BaseBookmarkModelObserver,
public PartnerBookmarksShim::Observer {
+ friend class BookmarksBridgeTestHelper;
Kibeom Kim (inactive) 2014/09/16 01:11:01 where is this class?
Ian Wen 2014/09/16 01:36:09 Mistake. Removed this line...
public:
BookmarksBridge(JNIEnv* env, jobject obj, jobject j_profile);
void Destroy(JNIEnv*, jobject);
@@ -31,6 +32,8 @@ class BookmarksBridge : public BaseBookmarkModelObserver,
bool IsDoingExtensiveChanges(JNIEnv* env, jobject obj);
+ void LoadEmptyPartnerBookmarkShimForTesting(JNIEnv* env, jobject obj);
+
base::android::ScopedJavaLocalRef<jobject> GetBookmarkByID(
JNIEnv* env,
jobject obj,
@@ -62,6 +65,12 @@ class BookmarksBridge : public BaseBookmarkModelObserver,
base::android::ScopedJavaLocalRef<jobject> GetMobileFolderId(JNIEnv* env,
jobject obj);
+ base::android::ScopedJavaLocalRef<jobject> GetOtherFolderId(JNIEnv* env,
+ jobject obj);
+
+ base::android::ScopedJavaLocalRef<jobject> GetDesktopFolderId(JNIEnv* env,
+ jobject obj);
+
void GetChildIDs(JNIEnv* env,
jobject obj,
jlong id,
@@ -100,9 +109,13 @@ class BookmarksBridge : public BaseBookmarkModelObserver,
jobject j_callback_obj,
jobject j_result_obj);
- void DeleteBookmark(JNIEnv* env,
- jobject obj,
- jobject j_bookmark_id_obj);
+ base::android::ScopedJavaLocalRef<jobject> AddFolder(JNIEnv* env,
+ jobject obj,
+ jobject j_parent_id_obj,
+ jint index,
+ jstring j_title);
+
+ void DeleteBookmark(JNIEnv* env, jobject obj, jobject j_bookmark_id_obj);
void MoveBookmark(JNIEnv* env,
jobject obj,
@@ -110,6 +123,14 @@ class BookmarksBridge : public BaseBookmarkModelObserver,
jobject j_parent_id_obj,
jint index);
+ base::android::ScopedJavaLocalRef<jobject> AddBookmark(
+ JNIEnv* env,
+ jobject obj,
+ jobject j_parent_id_obj,
+ jint index,
+ jstring j_title,
+ jstring j_url);
+
private:
virtual ~BookmarksBridge();

Powered by Google App Engine
This is Rietveld 408576698