Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: chrome/browser/android/bookmarks/bookmarks_bridge.h

Issue 550543003: Add Instrumental Test for BookmarksBridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
11 #include "base/android/jni_weak_ref.h" 11 #include "base/android/jni_weak_ref.h"
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
14 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 14 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
15 #include "chrome/browser/bookmarks/chrome_bookmark_client.h" 15 #include "chrome/browser/bookmarks/chrome_bookmark_client.h"
16 #include "components/bookmarks/browser/base_bookmark_model_observer.h" 16 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
17 #include "components/bookmarks/common/android/bookmark_id.h" 17 #include "components/bookmarks/common/android/bookmark_id.h"
18 18
19 class Profile; 19 class Profile;
20 20
21 // The delegate to fetch bookmarks information for the Android native 21 // The delegate to fetch bookmarks information for the Android native
22 // bookmark page. This fetches the bookmarks, title, urls, folder 22 // bookmark page. This fetches the bookmarks, title, urls, folder
23 // hierarchy. 23 // hierarchy.
24 class BookmarksBridge : public BaseBookmarkModelObserver, 24 class BookmarksBridge : public BaseBookmarkModelObserver,
25 public PartnerBookmarksShim::Observer { 25 public PartnerBookmarksShim::Observer {
26 friend class BookmarksBridgeTestHelper;
Kibeom Kim (inactive) 2014/09/16 01:11:01 where is this class?
Ian Wen 2014/09/16 01:36:09 Mistake. Removed this line...
26 public: 27 public:
27 BookmarksBridge(JNIEnv* env, jobject obj, jobject j_profile); 28 BookmarksBridge(JNIEnv* env, jobject obj, jobject j_profile);
28 void Destroy(JNIEnv*, jobject); 29 void Destroy(JNIEnv*, jobject);
29 30
30 static bool RegisterBookmarksBridge(JNIEnv* env); 31 static bool RegisterBookmarksBridge(JNIEnv* env);
31 32
32 bool IsDoingExtensiveChanges(JNIEnv* env, jobject obj); 33 bool IsDoingExtensiveChanges(JNIEnv* env, jobject obj);
33 34
35 void LoadEmptyPartnerBookmarkShimForTesting(JNIEnv* env, jobject obj);
36
34 base::android::ScopedJavaLocalRef<jobject> GetBookmarkByID( 37 base::android::ScopedJavaLocalRef<jobject> GetBookmarkByID(
35 JNIEnv* env, 38 JNIEnv* env,
36 jobject obj, 39 jobject obj,
37 jlong id, 40 jlong id,
38 jint type); 41 jint type);
39 42
40 void GetPermanentNodeIDs(JNIEnv* env, 43 void GetPermanentNodeIDs(JNIEnv* env,
41 jobject obj, 44 jobject obj,
42 jobject j_result_obj); 45 jobject j_result_obj);
43 46
(...skipping 11 matching lines...) Expand all
55 jobject obj, 58 jobject obj,
56 jobject j_result_obj); 59 jobject j_result_obj);
57 void GetAllFoldersWithDepths(JNIEnv* env, 60 void GetAllFoldersWithDepths(JNIEnv* env,
58 jobject obj, 61 jobject obj,
59 jobject j_folders_obj, 62 jobject j_folders_obj,
60 jobject j_depths_obj); 63 jobject j_depths_obj);
61 64
62 base::android::ScopedJavaLocalRef<jobject> GetMobileFolderId(JNIEnv* env, 65 base::android::ScopedJavaLocalRef<jobject> GetMobileFolderId(JNIEnv* env,
63 jobject obj); 66 jobject obj);
64 67
68 base::android::ScopedJavaLocalRef<jobject> GetOtherFolderId(JNIEnv* env,
69 jobject obj);
70
71 base::android::ScopedJavaLocalRef<jobject> GetDesktopFolderId(JNIEnv* env,
72 jobject obj);
73
65 void GetChildIDs(JNIEnv* env, 74 void GetChildIDs(JNIEnv* env,
66 jobject obj, 75 jobject obj,
67 jlong id, 76 jlong id,
68 jint type, 77 jint type,
69 jboolean get_folders, 78 jboolean get_folders,
70 jboolean get_bookmarks, 79 jboolean get_bookmarks,
71 jobject j_result_obj); 80 jobject j_result_obj);
72 81
73 void GetAllBookmarkIDsOrderedByCreationDate(JNIEnv* env, 82 void GetAllBookmarkIDsOrderedByCreationDate(JNIEnv* env,
74 jobject obj, 83 jobject obj,
(...skipping 18 matching lines...) Expand all
93 jobject j_folder_id_obj, 102 jobject j_folder_id_obj,
94 jobject j_callback_obj, 103 jobject j_callback_obj,
95 jobject j_result_obj); 104 jobject j_result_obj);
96 105
97 void GetCurrentFolderHierarchy(JNIEnv* env, 106 void GetCurrentFolderHierarchy(JNIEnv* env,
98 jobject obj, 107 jobject obj,
99 jobject j_folder_id_obj, 108 jobject j_folder_id_obj,
100 jobject j_callback_obj, 109 jobject j_callback_obj,
101 jobject j_result_obj); 110 jobject j_result_obj);
102 111
103 void DeleteBookmark(JNIEnv* env, 112 base::android::ScopedJavaLocalRef<jobject> AddFolder(JNIEnv* env,
104 jobject obj, 113 jobject obj,
105 jobject j_bookmark_id_obj); 114 jobject j_parent_id_obj,
115 jint index,
116 jstring j_title);
117
118 void DeleteBookmark(JNIEnv* env, jobject obj, jobject j_bookmark_id_obj);
106 119
107 void MoveBookmark(JNIEnv* env, 120 void MoveBookmark(JNIEnv* env,
108 jobject obj, 121 jobject obj,
109 jobject j_bookmark_id_obj, 122 jobject j_bookmark_id_obj,
110 jobject j_parent_id_obj, 123 jobject j_parent_id_obj,
111 jint index); 124 jint index);
112 125
126 base::android::ScopedJavaLocalRef<jobject> AddBookmark(
127 JNIEnv* env,
128 jobject obj,
129 jobject j_parent_id_obj,
130 jint index,
131 jstring j_title,
132 jstring j_url);
133
113 private: 134 private:
114 virtual ~BookmarksBridge(); 135 virtual ~BookmarksBridge();
115 136
116 base::android::ScopedJavaLocalRef<jobject> CreateJavaBookmark( 137 base::android::ScopedJavaLocalRef<jobject> CreateJavaBookmark(
117 const BookmarkNode* node); 138 const BookmarkNode* node);
118 void ExtractBookmarkNodeInformation( 139 void ExtractBookmarkNodeInformation(
119 const BookmarkNode* node, 140 const BookmarkNode* node,
120 jobject j_result_obj); 141 jobject j_result_obj);
121 const BookmarkNode* GetNodeByID(long node_id, int type); 142 const BookmarkNode* GetNodeByID(long node_id, int type);
122 const BookmarkNode* GetFolderWithFallback(long folder_id, int type); 143 const BookmarkNode* GetFolderWithFallback(long folder_id, int type);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 ChromeBookmarkClient* client_; // weak 192 ChromeBookmarkClient* client_; // weak
172 193
173 // Information about the Partner bookmarks (must check for IsLoaded()). 194 // Information about the Partner bookmarks (must check for IsLoaded()).
174 // This is owned by profile. 195 // This is owned by profile.
175 PartnerBookmarksShim* partner_bookmarks_shim_; 196 PartnerBookmarksShim* partner_bookmarks_shim_;
176 197
177 DISALLOW_COPY_AND_ASSIGN(BookmarksBridge); 198 DISALLOW_COPY_AND_ASSIGN(BookmarksBridge);
178 }; 199 };
179 200
180 #endif // CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 201 #endif // CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698