Add the ability to specify a default MIME type when loading a resource. We'l...

Add the ability to specify a default MIME type when loading a resource.  We'll need this to correctly load stylesheets that lack a Content-Type header in standards mode.

We're waiting on https://bugs.webkit.org/show_bug.cgi?id=24904 upstream before this works fully.  This change, as it stands, is a no-op.

R=wtc
BUG=7448
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12739

[abarth-chromium, 2009-03-28 00:14:55]

Here is the chrome-side part of the text/css fix.  Once we get the upstream
patch landed and merged, we can hook the two pieces up.

[wtc, 2009-03-28 00:45:35]

LGTM.  Thanks a lot!

http://codereview.chromium.org/55049/diff/1/5
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/55049/diff/1/5#newcode398
Line 398: request_data.default_mime_type,
Just curious: how do we decide if a piece of data should
be added to ExtraRequestInfo or to URLRequest itself?

If we add default_mime_type to URLRequest, it'll also work,
right?

http://codereview.chromium.org/55049/diff/1/7
File chrome/browser/renderer_host/resource_dispatcher_host.h (right):

http://codereview.chromium.org/55049/diff/1/7#newcode146
Line 146: // The MIME type to use if this request lacks a Content-Type header. 
If
Nit: "response header", to avoid confusion with a Content-Type
request header for a POST request.  Alternatively we can say
"the response to this request lacks a Content-Type header".

http://codereview.chromium.org/55049/diff/1/7#newcode147
Line 147: // |default_mime_type| is "", then use the default sniffing algorith.
Typo: algorith

http://codereview.chromium.org/55049/diff/1/2
File webkit/glue/resource_handle_impl.cc (right):

http://codereview.chromium.org/55049/diff/1/2#newcode429
Line 429: //                   request_.defaultMimeType());
Is this change blocked by your upstream WebKit patch?

[abarth-chromium, 2009-03-28 07:10:45]

http://codereview.chromium.org/55049/diff/1/5
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/55049/diff/1/5#newcode398
Line 398: request_data.default_mime_type,
In this case the decision is easy because URLRequest doesn't know anything about
content sniffing.  That's all handled at the ResourceDispatcherHost layer.

http://codereview.chromium.org/55049/diff/1/2
File webkit/glue/resource_handle_impl.cc (right):

http://codereview.chromium.org/55049/diff/1/2#newcode429
Line 429: //                   request_.defaultMimeType());
On 2009/03/28 00:45:35, wtc wrote:
> Is this change blocked by your upstream WebKit patch?

We can land this now, but it won't do anything yet because this API isn't
implemented in WebCore yet.  Once it is, we can uncomment this line.

[wtc, 2009-03-30 18:29:46]

LGTM.

http://codereview.chromium.org/55049/diff/1/5
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/55049/diff/1/5#newcode398
Line 398: request_data.default_mime_type,
On 2009/03/28 07:10:45, abarth wrote:
> In this case the decision is easy because URLRequest doesn't know anything
about
> content sniffing.  That's all handled at the ResourceDispatcherHost layer.

Thanks for the answer.  I also figured this out on my
way home last Friday -- if it'll be used or set by
URLRequest, add it as a member, otherwise it's "user data"
and we should add it to ExtraRequestInfo.