Add the ability to specify a default MIME type when loading a resource. We'l...

chrome/browser/renderer_host/resource_dispatcher_host.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
 
 #include <vector>
 
@@ skipping 377 matching lines @@
 
   // Make extra info and read footer (contains request ID).
   ExtraRequestInfo* extra_info =
       new ExtraRequestInfo(handler,
                            process_type,
                            process_id,
                            route_id,
                            request_id,
                            request_data.frame_origin,
                            request_data.main_frame_origin,
+                           request_data.default_mime_type,

[wtc, 2009/03/28 00:45:35]

Just curious: how do we decide if a piece of data should
be added to ExtraRequestInfo or to URLRequest itself?

If we add default_mime_type to URLRequest, it'll also work,
right?

[abarth-chromium, 2009/03/28 07:10:45]

In this case the decision is easy because URLRequest doesn't know anything about
content sniffing.  That's all handled at the ResourceDispatcherHost layer.

[wtc, 2009/03/30 18:29:46]

Thanks for the answer.  I also figured this out on my
way home last Friday -- if it'll be used or set by
URLRequest, add it as a member, otherwise it's "user data"
and we should add it to ExtraRequestInfo.

                            request_data.resource_type,
                            upload_size);
   extra_info->allow_download =
       ResourceType::IsFrame(request_data.resource_type);
   request->set_user_data(extra_info);  // takes pointer ownership
 
   BeginRequestInternal(request);
 }
 
 void ResourceDispatcherHost::OnDataReceivedACK(int request_id) {
@@ skipping 116 matching lines @@
   request->set_context(request_context);
 
   ExtraRequestInfo* extra_info =
       new ExtraRequestInfo(handler,
                            ChildProcessInfo::RENDER_PROCESS,
                            process_id,
                            route_id,
                            request_id_,
                            "null",  // frame_origin
                            "null",  // main_frame_origin
+                           "", // default_mime_type
                            ResourceType::SUB_RESOURCE,
                            0 /* upload_size */);
   extra_info->allow_download = true;
   extra_info->is_download = true;
   request->set_user_data(extra_info);  // Takes pointer ownership.
 
   BeginRequestInternal(request);
 }
 
 // This function is only used for saving feature.
@@ skipping 34 matching lines @@
   request->set_context(request_context);
 
   ExtraRequestInfo* extra_info =
       new ExtraRequestInfo(handler,
                            ChildProcessInfo::RENDER_PROCESS,
                            process_id,
                            route_id,
                            request_id_,
                            "null",  // frame_origin
                            "null",  // main_frame_origin
+                           "", // default_mime_type
                            ResourceType::SUB_RESOURCE,
                            0 /* upload_size */);
   // Just saving some resources we need, disallow downloading.
   extra_info->allow_download = false;
   extra_info->is_download = false;
   request->set_user_data(extra_info);  // Takes pointer ownership.
 
   BeginRequestInternal(request);
 }
 
@@ skipping 950 matching lines @@
     case ViewHostMsg_UploadProgress_ACK::ID:
     case ViewHostMsg_SyncLoad::ID:
       return true;
 
     default:
       break;
   }
 
   return false;
 }