Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 550453003: Fix inaccurate type condition in Hydrogen (Closed)

Created:
6 years, 3 months ago by rossberg
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix inaccurate type condition in Hydrogen R=bmeurer@chromium.org BUG=chromium:412210 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=23873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-cr412210.js View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 3 months ago (2014-09-09 15:43:03 UTC) #1
Benedikt Meurer
Didn't we agree on the regress-crbug-<ID>.js naming scheme some time ago? LGTM
6 years, 3 months ago (2014-09-10 04:09:54 UTC) #2
rossberg
On 2014/09/10 04:09:54, Benedikt Meurer wrote: > Didn't we agree on the regress-crbug-<ID>.js naming scheme ...
6 years, 3 months ago (2014-09-10 06:09:27 UTC) #3
rossberg
6 years, 3 months ago (2014-09-11 12:13:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698