Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: src/hydrogen.cc

Issue 550453003: Fix inaccurate type condition in Hydrogen (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-cr412210.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 35efe630aab242a6a88060021c55dd40c01df178..fddb8b020f3b8b64e332ba2471467cc74609c4c6 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -10253,7 +10253,7 @@ HValue* HGraphBuilder::BuildBinaryOperation(
right_type->Maybe(Type::String()) ||
right_type->Maybe(Type::Receiver()));
- if (left_type->Is(Type::None())) {
+ if (!left_type->IsInhabited()) {
Add<HDeoptimize>("Insufficient type feedback for LHS of binary operation",
Deoptimizer::SOFT);
// TODO(rossberg): we should be able to get rid of non-continuous
@@ -10264,7 +10264,7 @@ HValue* HGraphBuilder::BuildBinaryOperation(
left_rep = Representation::FromType(left_type);
}
- if (right_type->Is(Type::None())) {
+ if (!right_type->IsInhabited()) {
Add<HDeoptimize>("Insufficient type feedback for RHS of binary operation",
Deoptimizer::SOFT);
right_type = Type::Any(zone());
@@ -10761,7 +10761,7 @@ HControlInstruction* HOptimizedGraphBuilder::BuildCompareInstruction(
BailoutId bailout_id) {
// Cases handled below depend on collected type feedback. They should
// soft deoptimize when there is no type feedback.
- if (combined_type->Is(Type::None())) {
+ if (!combined_type->IsInhabited()) {
Add<HDeoptimize>("Insufficient type feedback for combined type "
"of binary operation",
Deoptimizer::SOFT);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-cr412210.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698