Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: Source/core/paint/BoxDecorationData.h

Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix debug build. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/BoxDecorationData.h
diff --git a/Source/core/paint/BoxDecorationData.h b/Source/core/paint/BoxDecorationData.h
new file mode 100644
index 0000000000000000000000000000000000000000..c78975f2ba9f1c09d1eedfc9361947fd94a9a69f
--- /dev/null
+++ b/Source/core/paint/BoxDecorationData.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BoxDecorationData_h
+#define BoxDecorationData_h
+
+#include "core/rendering/RenderBoxModelObject.h"
+#include "platform/graphics/Color.h"
+
+namespace blink {
+
+class RenderStyle;
+class GraphicsContext;
+
+// Information extracted from RenderStyle for box painting.
+class BoxDecorationData {
pdr. 2014/09/09 20:45:42 I feel like this is more of a struct than a class.
chrishtr 2014/09/09 22:38:18 Has public and private? I don't really have much o
+public:
+ BoxDecorationData(const RenderStyle&, bool canRenderBorderImage, bool backgroundHasOpaqueTopLayer, GraphicsContext*);
+
+ Color backgroundColor;
+ bool hasBackground;
+ bool hasBorder;
+ bool hasAppearance;
+ BackgroundBleedAvoidance bleedAvoidance;
pdr. 2014/09/09 20:45:42 Save 4 bytes with this one weird trick! Backgroun
chrishtr 2014/09/09 22:38:18 Done
+
+private:
+ BackgroundBleedAvoidance determineBackgroundBleedAvoidance(const RenderStyle&, bool canRenderBorderImage, bool backgroundHasOpaqueTopLayer, GraphicsContext*);
+ bool borderObscuresBackgroundEdge(const RenderStyle&, const FloatSize& contextScale) const;
+};
+
+} // namespace blink
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698