Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 550343002: Give the layout test harness better information to determine when to finish. (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Give the layout test harness better information to determine when to finish. Currently, blink's FrameLoader.cpp contains a complex, hacky function to determine when to inform the rest of chromium that loading is complete. This complexity is only necessary to support layout tests. This puts the requisite logic in the layout test harness. This logic is behind a temporary flag, in order to permit both blink and chromium to flip to the new definition of load completion simultaneously. BUG= Committed: https://crrev.com/46789a8b27fffe9c4d55b57fd21c3aef1dca1b69 Cr-Commit-Position: refs/heads/master@{#294085}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M build/common.gypi View 3 chunks +11 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 chunk +7 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 5 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nate Chapin
6 years, 3 months ago (2014-09-08 19:58:34 UTC) #2
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-09 23:29:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/550343002/20001
6 years, 3 months ago (2014-09-09 23:52:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a0363afe0b812b9e16f83a73da92bbf1d845228c
6 years, 3 months ago (2014-09-10 03:07:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46789a8b27fffe9c4d55b57fd21c3aef1dca1b69
Cr-Commit-Position: refs/heads/master@{#294085}

Powered by Google App Engine
This is Rietveld 408576698