Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3797)

Unified Diff: build/common.gypi

Issue 550343002: Give the layout test harness better information to determine when to finish. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/renderer/test_runner/web_test_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c605039d8330c9dc20dab8625c4125c1e2c2e1b1..e8735723f4d9e55ca42a8fa302fab044ff1e424f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -620,6 +620,13 @@
# Enable hole punching for the protected video.
'video_hole%': 0,
+ # Temporary hack to allow us to unify blink's definitions of load
+ # completion. blink uses a crazy set of constraints to determine load
+ # completion, but only actually requires them for layout tests. However,
+ # we need to maintain all the old behaviors while the plumbing is put in
+ # place on both sides of the repo boundary.
+ 'enable_load_completion_hacks%': 1,
+
# Automatically select platforms under ozone. Turn this off to
# build only explicitly selected platforms.
'ozone_auto_platforms%': 1,
@@ -1193,6 +1200,7 @@
'use_goma%': '<(use_goma)',
'gomadir%': '<(gomadir)',
'video_hole%': '<(video_hole)',
+ 'enable_load_completion_hacks%': '<(enable_load_completion_hacks)',
# Whether or not we are building the Athena shell.
'use_athena%': '0',
@@ -2938,6 +2946,9 @@
['video_hole==1', {
'defines': ['VIDEO_HOLE=1'],
}],
+ ['enable_load_completion_hacks==1', {
+ 'defines': ['ENABLE_LOAD_COMPLETION_HACKS=1'],
+ }],
], # conditions for 'target_defaults'
'target_conditions': [
['<(use_openssl)==1', {
« no previous file with comments | « no previous file | content/shell/renderer/test_runner/web_test_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698