Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: Source/core/BUILD.gn

Issue 550333003: Convert GN visibility to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | Source/core/inspector/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/BUILD.gn
diff --git a/Source/core/BUILD.gn b/Source/core/BUILD.gn
index f7f6524a3d3b9862c53cb4ce4e652b1b6d6179eb..c5e68aab4f3eaad85572595a2d304934732dfc46 100644
--- a/Source/core/BUILD.gn
+++ b/Source/core/BUILD.gn
@@ -13,7 +13,7 @@ import("//third_party/WebKit/Source/core/core.gni")
import("//third_party/WebKit/Source/build/scripts/scripts.gni")
import("//third_party/WebKit/Source/platform/platform_generated.gni")
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
rel_blink_core_gen_dir = rebase_path(blink_core_output_dir, root_build_dir)
@@ -122,7 +122,8 @@ source_set("prerequisites") {
#
# GYP version: WebKit/Source/core/core.gyp:webcore
source_set("core") {
- visibility = "//third_party/WebKit/*"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ "//third_party/WebKit/*" ]
exported_deps = [
":core_generated",
@@ -930,7 +931,8 @@ make_token_matcher("make_core_generated_make_token_matcher_for_viewport") {
# You can use Blink-in-JS in your local experiment, but don't ship it.
# crbug.com/341031
action("make_core_generated_private_script") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "../build/scripts/make_private_script_source.py"
inputs = [
@@ -949,7 +951,8 @@ action("make_core_generated_private_script") {
}
action("make_core_generated_private_script_for_testing") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "../build/scripts/make_private_script_source.py"
inputs = [
@@ -968,7 +971,8 @@ action("make_core_generated_private_script_for_testing") {
# "HTMLEntityTable" in make_core_generated from GYP.
action("make_core_generated_html_entity_table") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "html/parser/create-html-entity-table"
inputs = [
@@ -986,7 +990,8 @@ action("make_core_generated_html_entity_table") {
# "MediaQueryTokenizerCodepoints" in make_core_generated from GYP.
action("make_core_generated_media_query_tokenizer_codepoints") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "../build/scripts/make_mediaquery_tokenizer_codepoints.py"
outputs = [
@@ -1002,7 +1007,8 @@ action("make_core_generated_media_query_tokenizer_codepoints") {
# "UserAgentStyleSheets" in make_core_generated from GYP.
action("make_core_generated_user_agent_style_sheets") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "../build/scripts/make-file-arrays.py"
inputs = [
@@ -1043,7 +1049,8 @@ action("make_core_generated_user_agent_style_sheets") {
# "HTMLElementLookupTrie" in make_core_generated from GYP.
action("make_core_generated_html_element_lookup_trie") {
- visibility = ":make_core_generated"
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
script = "../build/scripts/make_element_lookup_trie.py"
input_file = "html/HTMLTagNames.in"
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | Source/core/inspector/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698