Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/core/BUILD.gn

Issue 550333003: Convert GN visibility to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | Source/core/inspector/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//third_party/WebKit/Source/bindings/bindings.gni") 6 import("//third_party/WebKit/Source/bindings/bindings.gni")
7 import("//third_party/WebKit/Source/bindings/core/v8/generated.gni") 7 import("//third_party/WebKit/Source/bindings/core/v8/generated.gni")
8 import("//third_party/WebKit/Source/bindings/modules/modules.gni") 8 import("//third_party/WebKit/Source/bindings/modules/modules.gni")
9 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni") 9 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
10 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 10 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
11 import("//third_party/WebKit/Source/config.gni") 11 import("//third_party/WebKit/Source/config.gni")
12 import("//third_party/WebKit/Source/core/core.gni") 12 import("//third_party/WebKit/Source/core/core.gni")
13 import("//third_party/WebKit/Source/build/scripts/scripts.gni") 13 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
14 import("//third_party/WebKit/Source/platform/platform_generated.gni") 14 import("//third_party/WebKit/Source/platform/platform_generated.gni")
15 15
16 visibility = "//third_party/WebKit/Source/*" 16 visibility = [ "//third_party/WebKit/Source/*" ]
17 17
18 rel_blink_core_gen_dir = rebase_path(blink_core_output_dir, root_build_dir) 18 rel_blink_core_gen_dir = rebase_path(blink_core_output_dir, root_build_dir)
19 19
20 # Compute the optimization level. The GYP code sets "optimize: max" which sets 20 # Compute the optimization level. The GYP code sets "optimize: max" which sets
21 # speed-over-size optimization for official builds on Windows only. The GN's 21 # speed-over-size optimization for official builds on Windows only. The GN's
22 # build optimize_max config applies this optimization on all platforms, so 22 # build optimize_max config applies this optimization on all platforms, so
23 # compute how to modify the config list to duplicate the GYP behavior. 23 # compute how to modify the config list to duplicate the GYP behavior.
24 if (is_debug) { 24 if (is_debug) {
25 core_config_remove = [ "//build/config/compiler:no_optimize" ] 25 core_config_remove = [ "//build/config/compiler:no_optimize" ]
26 core_config_add = core_config_remove # NOP 26 core_config_add = core_config_remove # NOP
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 ] 115 ]
116 } 116 }
117 117
118 # Note that this is a source set rather than a group, even though it has no 118 # Note that this is a source set rather than a group, even though it has no
119 # sources. A group would implicitly forward all direct dependent configs 119 # sources. A group would implicitly forward all direct dependent configs
120 # through it, but we want to keep our internal targets' 120 # through it, but we want to keep our internal targets'
121 # direct_dependent_configs private and only forward some of them. 121 # direct_dependent_configs private and only forward some of them.
122 # 122 #
123 # GYP version: WebKit/Source/core/core.gyp:webcore 123 # GYP version: WebKit/Source/core/core.gyp:webcore
124 source_set("core") { 124 source_set("core") {
125 visibility = "//third_party/WebKit/*" 125 visibility = [] # Allow re-assignment of list.
126 visibility = [ "//third_party/WebKit/*" ]
126 127
127 exported_deps = [ 128 exported_deps = [
128 ":core_generated", 129 ":core_generated",
129 "//skia", 130 "//skia",
130 "//third_party/npapi", 131 "//third_party/npapi",
131 "//third_party/qcms", 132 "//third_party/qcms",
132 "//third_party/WebKit/Source/platform", 133 "//third_party/WebKit/Source/platform",
133 "//third_party/WebKit/Source/wtf", 134 "//third_party/WebKit/Source/wtf",
134 "//url", 135 "//url",
135 "//v8", 136 "//v8",
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 output_file = "$blink_core_output_dir/HTMLMetaElement.cpp" 924 output_file = "$blink_core_output_dir/HTMLMetaElement.cpp"
924 } 925 }
925 926
926 # One-off scripts -------------------------------------------------------------- 927 # One-off scripts --------------------------------------------------------------
927 928
928 # "generatePrivateScript" in make_core_generated from GYP. 929 # "generatePrivateScript" in make_core_generated from GYP.
929 # FIXME: The implementation of Blink-in-JS is not yet mature. 930 # FIXME: The implementation of Blink-in-JS is not yet mature.
930 # You can use Blink-in-JS in your local experiment, but don't ship it. 931 # You can use Blink-in-JS in your local experiment, but don't ship it.
931 # crbug.com/341031 932 # crbug.com/341031
932 action("make_core_generated_private_script") { 933 action("make_core_generated_private_script") {
933 visibility = ":make_core_generated" 934 visibility = [] # Allow re-assignment of list.
935 visibility = [ ":make_core_generated" ]
934 script = "../build/scripts/make_private_script_source.py" 936 script = "../build/scripts/make_private_script_source.py"
935 937
936 inputs = [ 938 inputs = [
937 "../bindings/core/v8/PrivateScriptRunner.js", 939 "../bindings/core/v8/PrivateScriptRunner.js",
938 "html/HTMLMarqueeElement.js", 940 "html/HTMLMarqueeElement.js",
939 "xml/DocumentXMLTreeViewer.js", 941 "xml/DocumentXMLTreeViewer.js",
940 ] 942 ]
941 outputs = [ 943 outputs = [
942 "$blink_core_output_dir/PrivateScriptSources.h", 944 "$blink_core_output_dir/PrivateScriptSources.h",
943 ] 945 ]
944 946
945 args = rebase_path(outputs, root_build_dir) 947 args = rebase_path(outputs, root_build_dir)
946 args += rebase_path(inputs, root_build_dir) 948 args += rebase_path(inputs, root_build_dir)
947 949
948 deps = make_core_generated_deps 950 deps = make_core_generated_deps
949 } 951 }
950 952
951 action("make_core_generated_private_script_for_testing") { 953 action("make_core_generated_private_script_for_testing") {
952 visibility = ":make_core_generated" 954 visibility = [] # Allow re-assignment of list.
955 visibility = [ ":make_core_generated" ]
953 script = "../build/scripts/make_private_script_source.py" 956 script = "../build/scripts/make_private_script_source.py"
954 957
955 inputs = [ 958 inputs = [
956 "testing/PartialPrivateScriptTest.js", 959 "testing/PartialPrivateScriptTest.js",
957 "testing/PrivateScriptTest.js", 960 "testing/PrivateScriptTest.js",
958 ] 961 ]
959 outputs = [ 962 outputs = [
960 "$blink_core_output_dir/PrivateScriptSourcesForTesting.h", 963 "$blink_core_output_dir/PrivateScriptSourcesForTesting.h",
961 ] 964 ]
962 965
963 args = rebase_path(outputs, root_build_dir) 966 args = rebase_path(outputs, root_build_dir)
964 args += rebase_path(inputs, root_build_dir) 967 args += rebase_path(inputs, root_build_dir)
965 968
966 deps = make_core_generated_deps 969 deps = make_core_generated_deps
967 } 970 }
968 971
969 # "HTMLEntityTable" in make_core_generated from GYP. 972 # "HTMLEntityTable" in make_core_generated from GYP.
970 action("make_core_generated_html_entity_table") { 973 action("make_core_generated_html_entity_table") {
971 visibility = ":make_core_generated" 974 visibility = [] # Allow re-assignment of list.
975 visibility = [ ":make_core_generated" ]
972 script = "html/parser/create-html-entity-table" 976 script = "html/parser/create-html-entity-table"
973 977
974 inputs = [ 978 inputs = [
975 "html/parser/HTMLEntityNames.in", 979 "html/parser/HTMLEntityNames.in",
976 ] 980 ]
977 outputs = [ 981 outputs = [
978 "$blink_core_output_dir/HTMLEntityTable.cpp", 982 "$blink_core_output_dir/HTMLEntityTable.cpp",
979 ] 983 ]
980 984
981 args = [ "-o" ] + rebase_path(outputs, root_build_dir) 985 args = [ "-o" ] + rebase_path(outputs, root_build_dir)
982 args += rebase_path(inputs, root_build_dir) 986 args += rebase_path(inputs, root_build_dir)
983 987
984 deps = make_core_generated_deps 988 deps = make_core_generated_deps
985 } 989 }
986 990
987 # "MediaQueryTokenizerCodepoints" in make_core_generated from GYP. 991 # "MediaQueryTokenizerCodepoints" in make_core_generated from GYP.
988 action("make_core_generated_media_query_tokenizer_codepoints") { 992 action("make_core_generated_media_query_tokenizer_codepoints") {
989 visibility = ":make_core_generated" 993 visibility = [] # Allow re-assignment of list.
994 visibility = [ ":make_core_generated" ]
990 script = "../build/scripts/make_mediaquery_tokenizer_codepoints.py" 995 script = "../build/scripts/make_mediaquery_tokenizer_codepoints.py"
991 996
992 outputs = [ 997 outputs = [
993 "$blink_core_output_dir/MediaQueryTokenizerCodepoints.cpp", 998 "$blink_core_output_dir/MediaQueryTokenizerCodepoints.cpp",
994 ] 999 ]
995 1000
996 args = [ 1001 args = [
997 "--output_dir", rel_blink_core_gen_dir, 1002 "--output_dir", rel_blink_core_gen_dir,
998 ] 1003 ]
999 1004
1000 deps = make_core_generated_deps 1005 deps = make_core_generated_deps
1001 } 1006 }
1002 1007
1003 # "UserAgentStyleSheets" in make_core_generated from GYP. 1008 # "UserAgentStyleSheets" in make_core_generated from GYP.
1004 action("make_core_generated_user_agent_style_sheets") { 1009 action("make_core_generated_user_agent_style_sheets") {
1005 visibility = ":make_core_generated" 1010 visibility = [] # Allow re-assignment of list.
1011 visibility = [ ":make_core_generated" ]
1006 script = "../build/scripts/make-file-arrays.py" 1012 script = "../build/scripts/make-file-arrays.py"
1007 1013
1008 inputs = [ 1014 inputs = [
1009 "css/html.css", 1015 "css/html.css",
1010 "css/quirks.css", 1016 "css/quirks.css",
1011 "css/view-source.css", 1017 "css/view-source.css",
1012 "css/themeChromium.css", 1018 "css/themeChromium.css",
1013 "css/themeChromiumAndroid.css", 1019 "css/themeChromiumAndroid.css",
1014 "css/themeChromiumLinux.css", 1020 "css/themeChromiumLinux.css",
1015 "css/themeChromiumSkia.css", 1021 "css/themeChromiumSkia.css",
(...skipping 20 matching lines...) Expand all
1036 [ "--namespace", "blink" ] + 1042 [ "--namespace", "blink" ] +
1037 [ "--out-h=" + rebase_path(outputs[0], root_build_dir) ] + 1043 [ "--out-h=" + rebase_path(outputs[0], root_build_dir) ] +
1038 [ "--out-cpp=" + rebase_path(outputs[1], root_build_dir) ] + 1044 [ "--out-cpp=" + rebase_path(outputs[1], root_build_dir) ] +
1039 rebase_path(inputs, root_build_dir) 1045 rebase_path(inputs, root_build_dir)
1040 1046
1041 deps = make_core_generated_deps 1047 deps = make_core_generated_deps
1042 } 1048 }
1043 1049
1044 # "HTMLElementLookupTrie" in make_core_generated from GYP. 1050 # "HTMLElementLookupTrie" in make_core_generated from GYP.
1045 action("make_core_generated_html_element_lookup_trie") { 1051 action("make_core_generated_html_element_lookup_trie") {
1046 visibility = ":make_core_generated" 1052 visibility = [] # Allow re-assignment of list.
1053 visibility = [ ":make_core_generated" ]
1047 script = "../build/scripts/make_element_lookup_trie.py" 1054 script = "../build/scripts/make_element_lookup_trie.py"
1048 1055
1049 input_file = "html/HTMLTagNames.in" 1056 input_file = "html/HTMLTagNames.in"
1050 inputs = scripts_for_in_files + [ 1057 inputs = scripts_for_in_files + [
1051 input_file, 1058 input_file,
1052 "../build/scripts/templates/ElementLookupTrie.cpp.tmpl", 1059 "../build/scripts/templates/ElementLookupTrie.cpp.tmpl",
1053 "../build/scripts/templates/ElementLookupTrie.h.tmpl", 1060 "../build/scripts/templates/ElementLookupTrie.h.tmpl",
1054 ] 1061 ]
1055 outputs = [ 1062 outputs = [
1056 "$blink_core_output_dir/HTMLElementLookupTrie.cpp", 1063 "$blink_core_output_dir/HTMLElementLookupTrie.cpp",
(...skipping 20 matching lines...) Expand all
1077 "$blink_core_output_dir/{{source_name_part}}.h", 1084 "$blink_core_output_dir/{{source_name_part}}.h",
1078 ] 1085 ]
1079 args = [ 1086 args = [
1080 "{{source}}", 1087 "{{source}}",
1081 rel_blink_core_gen_dir, 1088 rel_blink_core_gen_dir,
1082 bison_exe, 1089 bison_exe,
1083 ] 1090 ]
1084 1091
1085 deps = make_core_generated_deps 1092 deps = make_core_generated_deps
1086 } 1093 }
OLDNEW
« no previous file with comments | « Source/bindings/scripts/BUILD.gn ('k') | Source/core/inspector/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698