Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 550333003: Convert GN visibility to lists. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, Mads Ager (chromium), eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, haraken, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kouhei+heap_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert GN visibility to lists. GN visibility currently allows either string or list types, but this is causing some problems for some templates. I'm going to require it to be lists, so am changing all callers before pushing the new binary. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M Source/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 8 chunks +15 lines, -8 lines 0 comments Download
M Source/core/inspector/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/platform/BUILD.gn View 6 chunks +11 lines, -6 lines 0 comments Download
M Source/platform/heap/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
brettw
6 years, 3 months ago (2014-09-08 20:33:15 UTC) #2
eseidel
lgtm
6 years, 3 months ago (2014-09-08 20:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/550333003/1
6 years, 3 months ago (2014-09-08 20:37:49 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 22:39:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181583

Powered by Google App Engine
This is Rietveld 408576698