Issue 550163002: Add optional mandatory policy setting for template generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 550163002: Add optional mandatory policy setting for template generation (Closed)

Created:
6 years, 3 months ago by Joao da Silva

Modified:
6 years, 3 months ago

Reviewers:

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add optional mandatory policy setting for template generation This CL modifies template writer such that mandatory policy templates are not generated when a flag is set. CL by kaliamoorthi@chromium.org, reviewed at https://codereview.chromium.org/544113002. BUG=410856 Committed: https://code.google.com/p/grit-i18n/source/detail?r=176

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+372 lines, -16 lines)			Patch
M	grit/format/policy_templates/writer_configuration.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer_unittest.py	View	1 chunk	+64 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer.py	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer_unittest.py	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/doc_writer.py	View	3 chunks	+13 lines, -3 lines	0 comments	Download
M	grit/format/policy_templates/writers/doc_writer_unittest.py	View	3 chunks	+58 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/json_writer.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/json_writer_unittest.py	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/plist_writer.py	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	grit/format/policy_templates/writers/plist_writer_unittest.py	View	1 chunk	+102 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/reg_writer.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	grit/format/policy_templates/writers/reg_writer_unittest.py	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/template_writer.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

6 years, 3 months ago (2014-09-08 14:09:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r176 (presubmit successful).

Expand Messages | Collapse Messages