Issue 55016: Don't order the bubble window front; it shows up just fine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55016: Don't order the bubble window front; it shows up just fine. (Closed)

Created:
11 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't order the bubble window front; it shows up just fine. Fix by Rohit. http://crbug.com/9422 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12655

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/cocoa/status_bubble_mac.mm	View		1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

http://codereview.chromium.org/55016/diff/1/2 File chrome/browser/cocoa/status_bubble_mac.mm (left): http://codereview.chromium.org/55016/diff/1/2#oldcode216 Line 216: [window_ orderFront:nil]; I noticed this with the omnibox ...

11 years, 8 months ago (2009-04-01 00:36:39 UTC) #3

Avi (use Gerrit)

11 years, 8 months ago (2009-04-01 00:48:06 UTC) #4

http://codereview.chromium.org/55016/diff/1/2
File chrome/browser/cocoa/status_bubble_mac.mm (left):

http://codereview.chromium.org/55016/diff/1/2#oldcode216
Line 216: [window_ orderFront:nil];
On 2009/04/01 00:36:39, shess wrote:
> Anyhow, does this change imply you want to move the
> -setAlpheValue: call above the -addChildWindow:ordered: call?

That might be a good idea, but for now this seems to work OK. If it turns out to
be flashing, I'll do that change.

Expand Messages | Collapse Messages