Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: chrome/browser/cocoa/status_bubble_mac.mm

Issue 55016: Don't order the bubble window front; it shows up just fine. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/status_bubble_mac.h" 5 #include "chrome/browser/cocoa/status_bubble_mac.h"
6 6
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "base/sys_string_conversions.h" 8 #include "base/sys_string_conversions.h"
9 #include "chrome/common/gfx/text_elider.h" 9 #include "chrome/common/gfx/text_elider.h"
10 #include "googleurl/src/gurl.h" 10 #include "googleurl/src/gurl.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 [window_ setOpaque:NO]; 206 [window_ setOpaque:NO];
207 [window_ setHasShadow:NO]; 207 [window_ setHasShadow:NO];
208 208
209 StatusBubbleViewCocoa* view = 209 StatusBubbleViewCocoa* view =
210 [[[StatusBubbleViewCocoa alloc] initWithFrame:NSZeroRect] autorelease]; 210 [[[StatusBubbleViewCocoa alloc] initWithFrame:NSZeroRect] autorelease];
211 [window_ setContentView:view]; 211 [window_ setContentView:view];
212 212
213 [parent_ addChildWindow:window_ ordered:NSWindowAbove]; 213 [parent_ addChildWindow:window_ ordered:NSWindowAbove];
214 214
215 [window_ setAlphaValue:0.0f]; 215 [window_ setAlphaValue:0.0f];
216 [window_ orderFront:nil];
Scott Hess - ex-Googler 2009/04/01 00:36:39 I noticed this with the omnibox things, too. I do
Avi (use Gerrit) 2009/04/01 00:48:06 That might be a good idea, but for now this seems
217 216
218 offset_ = 0; 217 offset_ = 0;
219 [view setStyle:STYLE_STANDARD]; 218 [view setStyle:STYLE_STANDARD];
220 MouseMoved(); 219 MouseMoved();
221 } 220 }
222 221
223 void StatusBubbleMac::FadeIn() { 222 void StatusBubbleMac::FadeIn() {
224 [NSAnimationContext beginGrouping]; 223 [NSAnimationContext beginGrouping];
225 [[NSAnimationContext currentContext] setDuration:kShowFadeDuration]; 224 [[NSAnimationContext currentContext] setDuration:kShowFadeDuration];
226 [[window_ animator] setAlphaValue:1.0f]; 225 [[window_ animator] setAlphaValue:1.0f];
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 316
318 NSDictionary* textDict = [NSDictionary dictionaryWithObjectsAndKeys: 317 NSDictionary* textDict = [NSDictionary dictionaryWithObjectsAndKeys:
319 textFont, NSFontAttributeName, 318 textFont, NSFontAttributeName,
320 textShadow, NSShadowAttributeName, 319 textShadow, NSShadowAttributeName,
321 nil]; 320 nil];
322 [content_ drawAtPoint:NSMakePoint(kTextPositionX, kTextPositionY) 321 [content_ drawAtPoint:NSMakePoint(kTextPositionX, kTextPositionY)
323 withAttributes:textDict]; 322 withAttributes:textDict];
324 } 323 }
325 324
326 @end 325 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698