tools/memory_inspector/memory_inspector/data/file_storage_unittest.py - Issue 550093003: [Android] Add 64-bit support to memdump (and memory_inspector parser)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/data/file_storage_unittest.py

Issue 550093003: [Android] Add 64-bit support to memdump (and memory_inspector parser) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/core/stacktrace.py ('k') | tools/memory_inspector/prebuilts/memdump-android-arm.sha1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/data/file_storage_unittest.py

diff --git a/tools/memory_inspector/memory_inspector/data/file_storage_unittest.py b/tools/memory_inspector/memory_inspector/data/file_storage_unittest.py

index 07458bc385d61e359d6bb15618e573a27cba5dbe..79ffd314167a4e837493e59abe004838cd7649d4 100644

--- a/tools/memory_inspector/memory_inspector/data/file_storage_unittest.py

+++ b/tools/memory_inspector/memory_inspector/data/file_storage_unittest.py

@@ -114,7 +114,7 @@ class FileStorageTest(unittest.TestCase):

if a is None:

return

- _BASICTYPES = (int, basestring, float)

+ _BASICTYPES = (long, int, basestring, float)

if isinstance(a, _BASICTYPES) and isinstance(b, _BASICTYPES):

return self.assertEqual(a, b, prefix)