tools/memory_inspector/memory_inspector/core/stacktrace.py - Issue 550093003: [Android] Add 64-bit support to memdump (and memory_inspector parser)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/core/stacktrace.py

Issue 550093003: [Android] Add 64-bit support to memdump (and memory_inspector parser) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/core/memory_map.py ('k') | tools/memory_inspector/memory_inspector/data/file_storage_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/core/stacktrace.py

diff --git a/tools/memory_inspector/memory_inspector/core/stacktrace.py b/tools/memory_inspector/memory_inspector/core/stacktrace.py

index b137a03ac82c82cbafb8b053a93676267c99113e..6b865b451f378f16c93965913f88b2220821fd2a 100644

--- a/tools/memory_inspector/memory_inspector/core/stacktrace.py

+++ b/tools/memory_inspector/memory_inspector/core/stacktrace.py

@@ -37,7 +37,7 @@ class Frame(object):

address: the absolute (virtual) address of the stack frame in the

original process virtual address space.

"""

- assert(isinstance(address, int))

+ assert(isinstance(address, (long, int)))

self.address = address

self.symbol = None

self.exec_file_rel_path = None

@@ -54,7 +54,7 @@ class Frame(object):

relative to the target device (e.g., /system/lib/libc.so).

offset: the offset in the executable.

"""

- assert(isinstance(offset, int))

+ assert(isinstance(offset, (long, int)))

self.exec_file_rel_path = exec_file_rel_path

self.offset = offset