Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 550083005: Merge FontPlatformDataHarfBuzz into FontPlatformData (Closed)

Created:
6 years, 3 months ago by Dominik Röttsches
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Merge FontPlatformDataHarfBuzz into FontPlatformData From WebKit legacy we have two redundant copies of this file. In order for switching shapers on mac, we need to fuse these files again. This is part two of the merge, after the headers were merged in r181655 / ad011a9df. BUG=334269 R=eae Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181754

Patch Set 1 #

Patch Set 2 : Includes Header Merge an Debug removal #

Patch Set 3 : GN build fix, mac duplicate symbol fix #

Patch Set 4 : Rebased #

Total comments: 1

Patch Set 5 : Trying to fix windows #

Patch Set 6 : Win Fix, 2nd attempt. #

Patch Set 7 : Mac uniqueId() nullptr issue fixed #

Patch Set 8 : Formatting fix in FontPlatformData.h (Daniel's comment) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -313 lines) Patch
M Source/platform/BUILD.gn View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/blink_platform.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -5 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 1 2 3 4 5 6 5 chunks +209 lines, -17 lines 0 comments Download
M Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm View 1 2 3 8 chunks +6 lines, -55 lines 0 comments Download
D Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 2 3 1 chunk +0 lines, -227 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dominik Röttsches
6 years, 3 months ago (2014-09-09 20:56:14 UTC) #2
Daniel Erat
one nit, but i'll let other people do the real review since i'm not very ...
6 years, 3 months ago (2014-09-09 21:17:13 UTC) #3
xhwang
I removed wangxiaohan from the reviewer list.
6 years, 3 months ago (2014-09-09 21:22:42 UTC) #5
eae
LGTM
6 years, 3 months ago (2014-09-10 00:06:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/550083005/140001
6 years, 3 months ago (2014-09-10 18:53:14 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:57:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as 181754

Powered by Google App Engine
This is Rietveld 408576698