Source/platform/BUILD.gn - Issue 550083005: Merge FontPlatformDataHarfBuzz into FontPlatformData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/BUILD.gn

Issue 550083005: Merge FontPlatformDataHarfBuzz into FontPlatformData (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Formatting fix in FontPlatformData.h (Daniel's comment) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/BUILD.gn

diff --git a/Source/platform/BUILD.gn b/Source/platform/BUILD.gn

index cdf14d84b98fd9c7702082dd40661228b500f796..154d902e87c95913fe44031b6ca754914a78624a 100644

--- a/Source/platform/BUILD.gn

+++ b/Source/platform/BUILD.gn

@@ -225,7 +225,6 @@ component("platform") {

if (is_mac) {

sources -= [

"fonts/harfbuzz/FontHarfBuzz.cpp",

- "fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp",

"fonts/harfbuzz/HarfBuzzFaceSkia.cpp",

"fonts/opentype/OpenTypeTypes.h",

"fonts/opentype/OpenTypeVerticalData.cpp",

@@ -262,9 +261,6 @@ component("platform") {

]

} else {

sources -= [

- # FIXME: We will eventually compile this too, but for now it's

- # only used on mac.

- "fonts/FontPlatformData.cpp",

"fonts/harfbuzz/HarfBuzzFaceCoreText.cpp",

"geometry/cg/FloatPointCG.cpp",

"geometry/cg/FloatRectCG.cpp",

« no previous file with comments | « no previous file | Source/platform/blink_platform.gyp » ('j') | no next file with comments »