Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 54993008: Simple Cache: Don't crash when logging MEDIA_CACHE histograms. (Closed)

Created:
7 years, 1 month ago by Deprecated (see juliatuttle)
Modified:
7 years, 1 month ago
Reviewers:
pasko, Yaron, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Simple Cache: Don't crash when logging MEDIA_CACHE histograms. BUG=314848 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/disk_cache/simple/simple_histogram_macros.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
LGTM
7 years, 1 month ago (2013-11-04 23:48:23 UTC) #1
pasko
lgtm, thanks!
7 years, 1 month ago (2013-11-05 00:07:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/54993008/1
7 years, 1 month ago (2013-11-05 02:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/54993008/1
7 years, 1 month ago (2013-11-05 03:14:37 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 04:00:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/54993008/1
7 years, 1 month ago (2013-11-05 04:54:25 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:41:18 UTC) #7
Message was sent while issue was closed.
Change committed as 232951

Powered by Google App Engine
This is Rietveld 408576698