Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: net/disk_cache/simple/simple_histogram_macros.h

Issue 54993008: Simple Cache: Don't crash when logging MEDIA_CACHE histograms. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_histogram_macros.h
diff --git a/net/disk_cache/simple/simple_histogram_macros.h b/net/disk_cache/simple/simple_histogram_macros.h
index 2107ad466a7a6125e56783b5884c13b84cb3b336..204deb21f90533a8991c320042f0e0e29abc9818 100644
--- a/net/disk_cache/simple/simple_histogram_macros.h
+++ b/net/disk_cache/simple/simple_histogram_macros.h
@@ -15,6 +15,8 @@
#define SIMPLE_CACHE_THUNK(uma_type, args) UMA_HISTOGRAM_##uma_type args
+// TODO(ttuttle): Add SimpleCache.Media.* histograms and call thunk in
+// MEDIA_CACHE case below.
#define SIMPLE_CACHE_UMA(uma_type, uma_name, cache_type, ...) \
do { \
switch (cache_type) { \
@@ -26,6 +28,8 @@
SIMPLE_CACHE_THUNK( \
uma_type, ("SimpleCache.App." uma_name, ##__VA_ARGS__)); \
break; \
+ case net::MEDIA_CACHE: \
+ break; \
default: \
NOTREACHED(); \
break; \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698