Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 549863004: Make ui gn check pass. Misc GN build improvements. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, sadrul, yoshiki+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ui gn check pass. Misc GN build improvements. Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is. R=jamesr@chromium.org Reland of https://codereview.chromium.org/545313002/ but with public/utility dependency added TBR=jamesr@chromium.org Committed: https://crrev.com/a78fdeda3324eab3427e2c8009c80fcaa906b675 Cr-Commit-Position: refs/heads/master@{#293646}

Patch Set 1 #

Patch Set 2 : fix utility linking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -17 lines) Patch
M build/config/BUILDCONFIG.gn View 5 chunks +8 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +44 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 5 chunks +45 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/generated_extensions_api.gni View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/shell_dialogs/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brettw
Previous patch is in patch set 1. This version adds a dependency on //content/public/utility from ...
6 years, 3 months ago (2014-09-06 22:36:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/549863004/20001
6 years, 3 months ago (2014-09-06 22:37:25 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a33cb4a847cb3d35327e9747e63cfdbd2092343c
6 years, 3 months ago (2014-09-07 00:31:58 UTC) #4
jamesr
lgtm
6 years, 3 months ago (2014-09-07 04:12:44 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:44 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a78fdeda3324eab3427e2c8009c80fcaa906b675
Cr-Commit-Position: refs/heads/master@{#293646}

Powered by Google App Engine
This is Rietveld 408576698