Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/shell_dialogs/BUILD.gn

Issue 549863004: Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix utility linking Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/BUILD.gn ('k') | ui/wm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/shell_dialogs/BUILD.gn
diff --git a/ui/shell_dialogs/BUILD.gn b/ui/shell_dialogs/BUILD.gn
index 3579f17e5d36b788b5af3c9c8f5bb201d99c6baa..dc9fd0938cdb44c812e4eb7cb74227c4db4912db 100644
--- a/ui/shell_dialogs/BUILD.gn
+++ b/ui/shell_dialogs/BUILD.gn
@@ -66,9 +66,6 @@ component("shell_dialogs") {
}
}
-# TODO(GYP) enable shell_dialogs_unittests when media is converted.
-if (false) {
-
test("shell_dialogs_unittests") {
sources = [
"select_file_dialog_win_unittest.cc",
@@ -82,5 +79,3 @@ test("shell_dialogs_unittests") {
"//testing/gtest",
]
}
-
-} # if false
« no previous file with comments | « ui/keyboard/BUILD.gn ('k') | ui/wm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698