Add a new version of RenderViewImpl::createView() with a suppress_opener flag.

Add a new version of RenderViewImpl::createView() with a suppress_opener flag.

This is step 1 of 4 in deleting FrameLoader::m_suppressOpenerInNewFrame, which
shouldn't need to be a class variable.

BUG=314177
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232893

[Charlie Reis, 2013-11-04 18:54:56]

LGTM, but I'm wondering if it would be easier to add it to WebWindowFeatures
instead, since it seems like it kind of fits in the category of data needed to
create a new window.

https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.h:430: bool suppress_opener);
Would this make sense on WebWindowFeatures?

[Nate Chapin, 2013-11-04 18:56:55]

On 2013/11/04 18:54:56, creis wrote:
> LGTM, but I'm wondering if it would be easier to add it to WebWindowFeatures
> instead, since it seems like it kind of fits in the category of data needed to
> create a new window.
> 
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> File content/renderer/render_view_impl.h (right):
> 
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> content/renderer/render_view_impl.h:430: bool suppress_opener);
> Would this make sense on WebWindowFeatures?

Interesting, that didn't occur to me. I'll look into that.

[Nate Chapin, 2013-11-04 19:31:12]

On 2013/11/04 18:56:55, Nate Chapin wrote:
> On 2013/11/04 18:54:56, creis wrote:
> > LGTM, but I'm wondering if it would be easier to add it to WebWindowFeatures
> > instead, since it seems like it kind of fits in the category of data needed
to
> > create a new window.
> > 
> >
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> > File content/renderer/render_view_impl.h (right):
> > 
> >
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> > content/renderer/render_view_impl.h:430: bool suppress_opener);
> > Would this make sense on WebWindowFeatures?
> 
> Interesting, that didn't occur to me. I'll look into that.

After some research and a 2nd opinion from abarth, I believe WebWindowFeatures
isn't the right answer. It mirrors blinks WindowFeatures class, which is pretty
explicitly used for parameters that can be given to window.open(). Suppressing
the opener doesn't fit that description.

[Charlie Reis, 2013-11-04 19:34:21]

On 2013/11/04 19:31:12, Nate Chapin wrote:
> On 2013/11/04 18:56:55, Nate Chapin wrote:
> > On 2013/11/04 18:54:56, creis wrote:
> > > LGTM, but I'm wondering if it would be easier to add it to
WebWindowFeatures
> > > instead, since it seems like it kind of fits in the category of data
needed
> to
> > > create a new window.
> > > 
> > >
> >
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> > > File content/renderer/render_view_impl.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/54983012/diff/1/content/renderer/render_view_...
> > > content/renderer/render_view_impl.h:430: bool suppress_opener);
> > > Would this make sense on WebWindowFeatures?
> > 
> > Interesting, that didn't occur to me. I'll look into that.
> 
> After some research and a 2nd opinion from abarth, I believe WebWindowFeatures
> isn't the right answer. It mirrors blinks WindowFeatures class, which is
pretty
> explicitly used for parameters that can be given to window.open(). Suppressing
> the opener doesn't fit that description.

Thanks for checking.  LGTM.

[commit-bot: I haz the power, 2013-11-04 19:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/54983012/1

[commit-bot: I haz the power, 2013-11-04 23:22:10]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 00:24:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/54983012/1

[commit-bot: I haz the power, 2013-11-05 03:14:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/54983012/1

[commit-bot: I haz the power, 2013-11-05 04:00:05]

Change committed as 232893