content/renderer/render_view_impl.h - Issue 54983012: Add a new version of RenderViewImpl::createView() with a suppress_opener flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 54983012: Add a new version of RenderViewImpl::createView() with a suppress_opener flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index ccfd1b59487098246356125ec467d27c2a2721cb..45a4c98b12f07be0ad2c44373660cc716095ba69 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -426,6 +426,14 @@ class CONTENT_EXPORT RenderViewImpl

const WebKit::WebURLRequest& request,

const WebKit::WebWindowFeatures& features,

const WebKit::WebString& frame_name,

+ WebKit::WebNavigationPolicy policy,

+ bool suppress_opener);

Charlie Reis 2013/11/04 18:54:56 Would this make sense on WebWindowFeatures?

+ // DEPRECATED

+ virtual WebKit::WebView* createView(

+ WebKit::WebFrame* creator,

+ const WebKit::WebURLRequest& request,

+ const WebKit::WebWindowFeatures& features,

+ const WebKit::WebString& frame_name,

WebKit::WebNavigationPolicy policy);

virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type);

virtual WebKit::WebExternalPopupMenu* createExternalPopupMenu(

« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »