Plumb native AppWindow input region through to window shape under Aura.

ui/views/widget/desktop_aura/desktop_root_window_host_win.cc

Index: ui/views/widget/desktop_aura/desktop_root_window_host_win.cc
diff --git a/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc b/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc
index 2dad0d94795fcbf6f6cd01ea1fff1d1b19e965ff..066e33a865c0529abff62871e37d3cef2339f6eb 100644
--- a/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc
+++ b/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc
@@ -233,9 +233,15 @@ gfx::Rect DesktopRootWindowHostWin::GetWorkAreaBoundsInScreen() const {
 }
 
 void DesktopRootWindowHostWin::SetShape(gfx::NativeRegion native_region) {
-  SkPath path;
-  native_region->getBoundaryPath(&path);
-  message_handler_->SetRegion(gfx::CreateHRGNFromSkPath(path));
+  if (native_region) {
+    SkPath path;
+    native_region->getBoundaryPath(&path);
+    message_handler_->SetRegion(gfx::CreateHRGNFromSkPath(path));
+  } else {
+    message_handler_->SetRegion(NULL);
+  }
+
+  delete native_region;

[Ben Goodger (Google), 2013/11/03 05:12:05]

was this called for by the method docs? if not, can you update the
documentation? were we leaking these regions?

[Wez, 2013/11/03 23:52:02]

The method has no docs (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/de...),
but Widget defines it as taking ownership (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...).

Since the DesktopNativeWidgetAura::SetShape() override just passes the region
through to the DesktopRootWindowHost implementations, it's currently leaking
under both X11 and Win32 (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/de...).

I've added a comment on DesktopRootWindowHost::SetShape(), and fixed the X11
implementation. Since this API is Aura-only and so gfx::NativeRegion is
SkRegion*, the param should really be scoped_ptr<SkRegion> - but perhaps you
prefer to avoid Skia dependencies in these headers?

 }
 
 void DesktopRootWindowHostWin::Activate() {