Plumb native AppWindow input region through to window shape under Aura.

ui/views/widget/desktop_aura/desktop_root_window_host_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_root_window_host_win.h"
 
 #include "base/win/metro.h"
 #include "third_party/skia/include/core/SkPath.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 215 matching lines @@
   MONITORINFO monitor_info;
   monitor_info.cbSize = sizeof(monitor_info);
   GetMonitorInfo(MonitorFromWindow(message_handler_->hwnd(),
                                    MONITOR_DEFAULTTONEAREST),
                  &monitor_info);
   gfx::Rect pixel_bounds = gfx::Rect(monitor_info.rcWork);
   return gfx::win::ScreenToDIPRect(pixel_bounds);
 }
 
 void DesktopRootWindowHostWin::SetShape(gfx::NativeRegion native_region) {
-  SkPath path;
-  native_region->getBoundaryPath(&path);
-  message_handler_->SetRegion(gfx::CreateHRGNFromSkPath(path));
+  if (native_region) {
+    SkPath path;
+    native_region->getBoundaryPath(&path);
+    message_handler_->SetRegion(gfx::CreateHRGNFromSkPath(path));
+  } else {
+    message_handler_->SetRegion(NULL);
+  }
+
+  delete native_region;

[Ben Goodger (Google), 2013/11/03 05:12:05]

was this called for by the method docs? if not, can you update the
documentation? were we leaking these regions?

[Wez, 2013/11/03 23:52:02]

The method has no docs (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/de...),
but Widget defines it as taking ownership (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...).

Since the DesktopNativeWidgetAura::SetShape() override just passes the region
through to the DesktopRootWindowHost implementations, it's currently leaking
under both X11 and Win32 (see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/de...).

I've added a comment on DesktopRootWindowHost::SetShape(), and fixed the X11
implementation. Since this API is Aura-only and so gfx::NativeRegion is
SkRegion*, the param should really be scoped_ptr<SkRegion> - but perhaps you
prefer to avoid Skia dependencies in these headers?

 }
 
 void DesktopRootWindowHostWin::Activate() {
   message_handler_->Activate();
 }
 
 void DesktopRootWindowHostWin::Deactivate() {
   message_handler_->Deactivate();
 }
 
@@ skipping 620 matching lines @@
 
 // static
 DesktopRootWindowHost* DesktopRootWindowHost::Create(
     internal::NativeWidgetDelegate* native_widget_delegate,
     DesktopNativeWidgetAura* desktop_native_widget_aura) {
   return new DesktopRootWindowHostWin(native_widget_delegate,
                                       desktop_native_widget_aura);
 }
 
 }  // namespace views