Issue 549803003: Rename tabBase to tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549803003: Rename tabBase to tab (Closed)

Created:
6 years, 3 months ago by wajahat

Modified:
6 years, 3 months ago

Reviewers:
Ted C, Bernhard Bauer, Yaron

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Rename tabBase to tab In EmptyTabObserver tabBase needs to be renamed to tab as per patch https://codereview.chromium.org/148523013 BUG=339423 Committed: https://crrev.com/7a06cb2e0d3edf4a7bd4e94f0a6292d13b871489 Cr-Commit-Position: refs/heads/master@{#294807}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549803003/1

6 years, 3 months ago (2014-09-15 11:53:58 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as f7a983c21d75ef5fbc8d7633dc142f1610fa75d1

6 years, 3 months ago (2014-09-15 12:52:44 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 12:56:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7a06cb2e0d3edf4a7bd4e94f0a6292d13b871489
Cr-Commit-Position: refs/heads/master@{#294807}