Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 54973005: Do not show menu items added by extensions inside <webview>. (Closed)

Created:
7 years, 1 month ago by lazyboy
Modified:
7 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not show menu items added by extensions inside <webview>. <webview>'s are supposed to be isolated from regular tab/pages, so context menus from other extensions should not appear inside them. BUG=313907 Test=Install some extension that can add a context menu item to some page, now create an app with <webview> in it and navigate the <webview> to that page that shows the context menu in regular tab. Notice that the added context menu item does not appear anymore inside the <webview>. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lazyboy
+avi for review.
7 years, 1 month ago (2013-11-01 18:41:59 UTC) #1
Avi (use Gerrit)
lgtm
7 years, 1 month ago (2013-11-01 18:56:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/54973005/1
7 years, 1 month ago (2013-11-01 19:36:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217673
7 years, 1 month ago (2013-11-01 22:32:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/54973005/1
7 years, 1 month ago (2013-11-01 22:56:59 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 02:04:08 UTC) #6
Message was sent while issue was closed.
Change committed as 232556

Powered by Google App Engine
This is Rietveld 408576698