android_webview/renderer/print_web_view_helper_android.cc - Issue 54963005: Upstream printing changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/print_web_view_helper_android.cc

Issue 54963005: Upstream printing changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrow the scope of deps Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/renderer/print_web_view_helper_android.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_android.cc b/android_webview/renderer/print_web_view_helper_android.cc

similarity index 69%

copy from chrome/renderer/printing/print_web_view_helper_android.cc

copy to android_webview/renderer/print_web_view_helper_android.cc

index 95da0ce82ec6df1a7501216a84072314870da031..d5eeaa7827a959e65d9eb35ea841b780aac8c7ab 100644

--- a/chrome/renderer/printing/print_web_view_helper_android.cc

+++ b/android_webview/renderer/print_web_view_helper_android.cc

@@ -4,4 +4,7 @@

// All the necessary logic already lives in print_web_view_helper_linux.cc.

// We need a separate file for Android due to build/filename_rules.gypi rules.

-#include "chrome/renderer/printing/print_web_view_helper_linux.cc"

+// TODO(sgurun) copied from chrome/renderer. Remove after crbug.com/322276

+#include "android_webview/renderer/print_web_view_helper_linux.cc"

Lei Zhang 2013/11/25 22:00:15 Are you doing this just to keep in sync with the c

joth 2013/11/25 22:19:03 Ah good point. I think we could just put the conte

sgurun-gerrit only 2013/11/25 23:30:21 Yep, exactly to be in sync as much as possible. Th