android_webview/renderer/print_web_view_helper_android.cc - Issue 54963005: Upstream printing changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/renderer/print_web_view_helper_android.cc

Issue 54963005: Upstream printing changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrow the scope of deps Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // All the necessary logic already lives in print_web_view_helper_linux.cc.	5 // All the necessary logic already lives in print_web_view_helper_linux.cc.

6 // We need a separate file for Android due to build/filename_rules.gypi rules.	6 // We need a separate file for Android due to build/filename_rules.gypi rules.

7 #include "chrome/renderer/printing/print_web_view_helper_linux.cc"	7

	8 // TODO(sgurun) copied from chrome/renderer. Remove after crbug.com/322276

	9

	10 #include "android_webview/renderer/print_web_view_helper_linux.cc"
	Lei Zhang 2013/11/25 22:00:15 Are you doing this just to keep in sync with the c Are you doing this just to keep in sync with the chrome/renderer version as much as possible? joth 2013/11/25 22:19:03 Ah good point. I think we could just put the conte Show quoted text On 2013/11/25 22:00:15, Lei Zhang wrote: > Are you doing this just to keep in sync with the chrome/renderer version as much > as possible? Ah good point. I think we could just put the content in this file and give an exact comment as to which file it was based on. sgurun-gerrit only 2013/11/25 23:30:21 Yep, exactly to be in sync as much as possible. Th Yep, exactly to be in sync as much as possible. This is a throw away code so will go away soon hopefully. On 2013/11/25 22:19:03, joth wrote: Show quoted text > On 2013/11/25 22:00:15, Lei Zhang wrote: > > Are you doing this just to keep in sync with the chrome/renderer version as > much > > as possible? > > Ah good point. I think we could just put the content in this file and give an > exact comment as to which file it was based on.
OLD	NEW

« android_webview/common/DEPS ('K') | « android_webview/renderer/print_web_view_helper.cc ('k') | android_webview/renderer/print_web_view_helper_linux.cc » ('j') | no next file with comments »