Upstream printing changes.

For implementing printing in android K release, we had to temporarily
fork chromium. The first patchset below is equivalent to what we have
in KLP branch (minus machine generated makefiles). 

This is to unfork the implementation.

Note that the print messages and print_web_view_helper are same (or
very slightly different) from their counterpart in
chrome/renderer/printing and chrome/common/print_messages. The plan is
to start componentizing printing immediately after and remove the
duplicate code

TBR=danakj@chromium.org
BUG=322276
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238196

[sgurun-gerrit only, 2013-11-02 03:05:49]

ptal, thanks

[joth, 2013-11-04 20:30:37]

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
File android_webview/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
android_webview/renderer/print_web_view_helper.cc:46: 
should we put a comment here about where this was copied from, that OS_ANDROID
is used in most places as a marker of the differences from that source, and TODO
/ bug link for the componentization work needed to converge the two copies?

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
android_webview/renderer/print_web_view_helper.cc:278:
frame->document().to<WebKit::WebPluginDocument>().plugin() : NULL;
this will always return NULL for webview. Is this update just to make it look
more consistent with the //chrome version?

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi#newcode543
build/common.gypi:543: # completely for WebView.
needs update

[Peter Beverloo, 2013-11-12 13:38:28]

Could you please write a clearer description for this CL, since it's hard to
understand for people without context.  Please refer to a (public) Chromium bug
as well.

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi#newcode544
build/common.gypi:544: ['OS=="android"', {
You can also consolidate this with the conditional block on line 528-540.

[sgurun-gerrit only, 2013-11-13 21:49:53]

On 2013/11/12 13:38:28, Peter Beverloo wrote:
> Could you please write a clearer description for this CL, since it's hard to
> understand for people without context.  Please refer to a (public) Chromium
bug
> as well.
> 
> https://codereview.chromium.org/54963005/diff/70001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/54963005/diff/70001/build/common.gypi#newcode544
> build/common.gypi:544: ['OS=="android"', {
> You can also consolidate this with the conditional block on line 528-540.

sure will do.

[sgurun-gerrit only, 2013-11-21 18:25:42]

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
File android_webview/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
android_webview/renderer/print_web_view_helper.cc:46: 
On 2013/11/04 20:30:38, joth wrote:
> should we put a comment here about where this was copied from, that OS_ANDROID
> is used in most places as a marker of the differences from that source, and
TODO
> / bug link for the componentization work needed to converge the two copies?

Done.

https://codereview.chromium.org/54963005/diff/70001/android_webview/renderer/...
android_webview/renderer/print_web_view_helper.cc:278:
frame->document().to<WebKit::WebPluginDocument>().plugin() : NULL;
On 2013/11/04 20:30:38, joth wrote:
> this will always return NULL for webview. Is this update just to make it look
> more consistent with the //chrome version?

yep

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi#newcode543
build/common.gypi:543: # completely for WebView.
On 2013/11/04 20:30:38, joth wrote:
> needs update

Done.

https://codereview.chromium.org/54963005/diff/70001/build/common.gypi#newcode544
build/common.gypi:544: ['OS=="android"', {
good point.

On 2013/11/12 13:38:29, Peter Beverloo wrote:
> You can also consolidate this with the conditional block on line 528-540.

[sgurun-gerrit only, 2013-11-21 18:33:23]

joth: PTAL to the all CL
palmer: please review android_webview/common/print_messages

[joth, 2013-11-21 19:38:02]

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/DEPS
File android_webview/common/DEPS (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/D...
android_webview/common/DEPS:8: "+ui/gfx",
group these three together with a TODO to remove when printing is componentized?
(crbug link for that work?)

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/p...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/p...
android_webview/common/print_messages.h:4: 
For all the files copied from //chrome can we add a comment that it's a
duplicated and will be removed as part of componentization? (crbug link?)

https://codereview.chromium.org/54963005/diff/580001/android_webview/java/src...
File
android_webview/java/src/org/chromium/android_webview/AwPdfExportAttributes.java
(right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwPdfExportAttributes.java:10:
public class AwPdfExportAttributes {
Is this class even needed now? It's purpose was to allow us to upstream without
dep on the KK SDK but now we have that, we might as well just use
PrintAttributes throughout.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_contents.cc:395: 
spurious \n

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_contents.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_contents.h:89: public:
remove me

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_pdf_exporter.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.cc:34: 
spurious \n

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.cc:112: // TODO(sgurun) implement
TODO(sgurun): implement. Needs connecting with the |cancel_signal| passed in the
constructor.

(right?)

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_pdf_exporter.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:16: #include
"third_party/skia/include/core/SkPicture.h"
remove me

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:31: 
spurious \n

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:47: bool IsCancelled();
virtual & OVERRIDE

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
File android_webview/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.cc:1651: // Shows scripted print
preview in two stages.
nit indent

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.cc:1697: 
nit - \n

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
File android_webview/renderer/print_web_view_helper.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.h:119: 
- \n

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.h:193: // TODO(sgurun)
android_webview disables scripted prints by default.
rather than the edits here, can this just be called from inside the c'tor?

This TODO is to add window.print support? That's probably best just tracked in
crbug I think.

[Torne, 2013-11-21 23:56:26]

I'm updating the automerger and AOSP bot configurations to add the sfntly
sources needed by this change; I'll comment when this is done.

[Torne, 2013-11-22 00:30:42]

sfntly is now in the deps whitelist as of r236647, so if you kick off an
android_aosp tryjob on that revision or later, it should work :)

[Torne, 2013-11-22 00:30:44]

sfntly is now in the deps whitelist as of r236647, so if you kick off an
android_aosp tryjob on that revision or later, it should work :)

[joth, 2013-11-23 01:31:13]

lgtm

[sgurun-gerrit only, 2013-11-23 01:49:11]

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/DEPS
File android_webview/common/DEPS (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/D...
android_webview/common/DEPS:8: "+ui/gfx",
On 2013/11/21 19:38:03, joth wrote:
> group these three together with a TODO to remove when printing is
componentized?
> (crbug link for that work?)

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/p...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/common/p...
android_webview/common/print_messages.h:4: 
On 2013/11/21 19:38:03, joth wrote:
> For all the files copied from //chrome can we add a comment that it's a
> duplicated and will be removed as part of componentization? (crbug link?)

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/java/src...
File
android_webview/java/src/org/chromium/android_webview/AwPdfExportAttributes.java
(right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwPdfExportAttributes.java:10:
public class AwPdfExportAttributes {
On 2013/11/21 19:38:03, joth wrote:
> Is this class even needed now? It's purpose was to allow us to upstream
without
> dep on the KK SDK but now we have that, we might as well just use
> PrintAttributes throughout.

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_contents.cc:395: 
On 2013/11/21 19:38:03, joth wrote:
> spurious \n

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_contents.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_contents.h:89: public:
On 2013/11/21 19:38:03, joth wrote:
> remove me

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_pdf_exporter.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.cc:34: 
On 2013/11/21 19:38:03, joth wrote:
> spurious \n

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.cc:112: // TODO(sgurun) implement
On 2013/11/21 19:38:03, joth wrote:
> TODO(sgurun): implement. Needs connecting with the |cancel_signal| passed in
the
> constructor.
> 
> (right?)

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
File android_webview/native/aw_pdf_exporter.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:16: #include
"third_party/skia/include/core/SkPicture.h"
On 2013/11/21 19:38:03, joth wrote:
> remove me

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:31: 
On 2013/11/21 19:38:03, joth wrote:
> spurious \n 

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/native/a...
android_webview/native/aw_pdf_exporter.h:47: bool IsCancelled();
On 2013/11/21 19:38:03, joth wrote:
> virtual & OVERRIDE 

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
File android_webview/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.cc:1651: // Shows scripted print
preview in two stages.
On 2013/11/21 19:38:03, joth wrote:
> nit indent

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.cc:1697: 
On 2013/11/21 19:38:03, joth wrote:
> nit - \n

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
File android_webview/renderer/print_web_view_helper.h (right):

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.h:119: 
On 2013/11/21 19:38:03, joth wrote:
> - \n

Done.

https://codereview.chromium.org/54963005/diff/580001/android_webview/renderer...
android_webview/renderer/print_web_view_helper.h:193: // TODO(sgurun)
android_webview disables scripted prints by default.
On 2013/11/21 19:38:03, joth wrote:
> rather than the edits here, can this just be called from inside the c'tor?
> 
> This TODO is to add window.print support? That's probably best just tracked in
> crbug I think.

Done.

[sgurun-gerrit only, 2013-11-25 20:29:24]

@thestig need LGTM for adding printing to DEPS
@tkent need LGTM for adding third_party/WebKit/public/web to DEPS
@danakj need LGTM for adding some primitive graphics types to DEPS

Note that once the print componentization work is complete, we will remove these
DEPS

[Peter Beverloo, 2013-11-25 20:49:23]

Please refer to a public bug as well.

[Lei Zhang, 2013-11-25 22:00:14]

DEPS change lgtm

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
File android_webview/renderer/print_web_view_helper_android.cc (right):

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
android_webview/renderer/print_web_view_helper_android.cc:10: #include
"android_webview/renderer/print_web_view_helper_linux.cc"
Are you doing this just to keep in sync with the chrome/renderer version as much
as possible?

[joth, 2013-11-25 22:19:02]

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
File android_webview/renderer/print_web_view_helper_android.cc (right):

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
android_webview/renderer/print_web_view_helper_android.cc:10: #include
"android_webview/renderer/print_web_view_helper_linux.cc"
On 2013/11/25 22:00:15, Lei Zhang wrote:
> Are you doing this just to keep in sync with the chrome/renderer version as
much
> as possible?

Ah good point. I think we could just put the content in this file and give an
exact comment as to which file it was based on.

[sgurun-gerrit only, 2013-11-25 23:30:21]

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
File android_webview/renderer/print_web_view_helper_android.cc (right):

https://codereview.chromium.org/54963005/diff/1000001/android_webview/rendere...
android_webview/renderer/print_web_view_helper_android.cc:10: #include
"android_webview/renderer/print_web_view_helper_linux.cc"
Yep, exactly to be in sync as much as possible. This is a throw away code so
will go away soon hopefully.

On 2013/11/25 22:19:03, joth wrote:
> On 2013/11/25 22:00:15, Lei Zhang wrote:
> > Are you doing this just to keep in sync with the chrome/renderer version as
> much
> > as possible?
> 
> Ah good point. I think we could just put the content in this file and give an
> exact comment as to which file it was based on.

[tkent, 2013-11-26 06:43:07]

https://codereview.chromium.org/54963005/diff/1000001/android_webview/common/...
File android_webview/common/DEPS (right):

https://codereview.chromium.org/54963005/diff/1000001/android_webview/common/...
android_webview/common/DEPS:7:
"+third_party/WebKit/public/web/WebPrintScalingOption.h",
lgtm.
Adding it because a source file is copied. It's understandable.

[joth, 2013-11-27 19:26:07]

On 2013/11/26 06:43:07, tkent wrote:
>
https://codereview.chromium.org/54963005/diff/1000001/android_webview/common/...
> File android_webview/common/DEPS (right):
> 
>
https://codereview.chromium.org/54963005/diff/1000001/android_webview/common/...
> android_webview/common/DEPS:7:
> "+third_party/WebKit/public/web/WebPrintScalingOption.h",
> lgtm.
> Adding it because a source file is copied. It's understandable.

I'm adding TBR=danakj@chromium.org for android_webview/common/DEPS (adding
ui/gfx deps but this is just the same as chrome has)

[commit-bot: I haz the power, 2013-11-27 19:30:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/54963005/1000001

[commit-bot: I haz the power, 2013-11-27 19:30:25]

Failed to apply patch for android_webview/renderer/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file android_webview/renderer/DEPS
  Hunk #1 FAILED at 8.
  1 out of 1 hunk FAILED -- saving rejects to file
android_webview/renderer/DEPS.rej

Patch:       android_webview/renderer/DEPS
Index: android_webview/renderer/DEPS
diff --git a/android_webview/renderer/DEPS b/android_webview/renderer/DEPS
index
d786dba51341584b8b86b3c578a1da65a6509032..ee3a3f948526301dde5e283533d61e055b941018
100644
--- a/android_webview/renderer/DEPS
+++ b/android_webview/renderer/DEPS
@@ -8,9 +8,11 @@ include_rules = [
 
   "+content/public/renderer",
 
+  "+printing",
+
   "+third_party/WebKit/public/platform",
   "+third_party/WebKit/public/web",
 
-  "+ui/gfx/size.h",
+  "+ui/gfx",
   "+ui/gl/gpu_memory_buffer.h",
 ]

[commit-bot: I haz the power, 2013-12-02 19:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/54963005/1020001

[commit-bot: I haz the power, 2013-12-02 21:52:04]

Change committed as 238196