Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 549423002: PrintingHandler in utility process is required for Windows even without full printing. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_patches
Project:
chromium
Visibility:
Public.

Description

PrintingHandler in utility process is required for Windows even without full printing. Makes possible to print from windows with printing_enabled=2. BUG=374321 Committed: https://crrev.com/ef3bf565f3665bf105d8700b837261ced348db46 Cr-Commit-Position: refs/heads/master@{#293984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/chrome_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/printing_handler.h View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/utility/printing_handler.cc View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-09 07:05:36 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-09 18:30:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/549423002/1
6 years, 3 months ago (2014-09-09 18:39:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 04b0573da79a58bd6e85721cbe1345efc511c2bc
6 years, 3 months ago (2014-09-09 19:20:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef3bf565f3665bf105d8700b837261ced348db46
Cr-Commit-Position: refs/heads/master@{#293984}

Powered by Google App Engine
This is Rietveld 408576698