Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/utility/printing_handler.h

Issue 549423002: PrintingHandler in utility process is required for Windows even without full printing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_patches
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/chrome_content_utility_client.cc ('k') | chrome/utility/printing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/printing_handler.h
diff --git a/chrome/utility/printing_handler.h b/chrome/utility/printing_handler.h
index 4eecd788e3effa2fb93e3149ffd08cb9bbc4e189..d0135f5b2ba84f7be5e34ec46b654aef0854cd6c 100644
--- a/chrome/utility/printing_handler.h
+++ b/chrome/utility/printing_handler.h
@@ -10,8 +10,8 @@
#include "chrome/utility/utility_message_handler.h"
#include "ipc/ipc_platform_file.h"
-#if !defined(ENABLE_FULL_PRINTING)
-#error "Full printing must be enabled"
+#if !defined(ENABLE_FULL_PRINTING) && !defined(OS_WIN)
+#error "Windows or full printing must be enabled"
#endif
namespace printing {
@@ -40,11 +40,13 @@ class PrintingHandler : public UtilityMessageHandler {
const printing::PdfRenderSettings& settings,
const std::vector<printing::PageRange>& page_ranges);
#endif // OS_WIN
+#if defined(ENABLE_FULL_PRINTING)
void OnRenderPDFPagesToPWGRaster(
IPC::PlatformFileForTransit pdf_transit,
const printing::PdfRenderSettings& settings,
const printing::PwgRasterSettings& bitmap_settings,
IPC::PlatformFileForTransit bitmap_transit);
+#endif // ENABLE_FULL_PRINTING
#if defined(OS_WIN)
// Helper method for Windows.
@@ -60,7 +62,7 @@ class PrintingHandler : public UtilityMessageHandler {
int* highest_rendered_page_number,
double* scale_factor);
#endif // OS_WIN
-
+#if defined(ENABLE_FULL_PRINTING)
bool RenderPDFPagesToPWGRaster(
base::File pdf_file,
const printing::PdfRenderSettings& settings,
@@ -69,6 +71,7 @@ class PrintingHandler : public UtilityMessageHandler {
void OnGetPrinterCapsAndDefaults(const std::string& printer_name);
void OnGetPrinterSemanticCapsAndDefaults(const std::string& printer_name);
+#endif // ENABLE_FULL_PRINTING
DISALLOW_COPY_AND_ASSIGN(PrintingHandler);
};
« no previous file with comments | « chrome/utility/chrome_content_utility_client.cc ('k') | chrome/utility/printing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698