Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 549343002: Add various fields of the QUIC ack frame to net-internals. (Closed)

Created:
6 years, 3 months ago by Ryan Hamilton
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add various fields of the QUIC ack frame to net-internals. BUG=331982 Committed: https://crrev.com/36c907908a398eb2d483227891165937ad473e0e Cr-Commit-Position: refs/heads/master@{#293908}

Patch Set 1 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M net/quic/quic_connection_logger.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Ryan Hamilton
6 years, 3 months ago (2014-09-08 22:48:26 UTC) #3
Jana
lgtm Thanks for doing this, Ryan.
6 years, 3 months ago (2014-09-08 23:00:21 UTC) #4
Ryan Hamilton
6 years, 3 months ago (2014-09-09 00:18:34 UTC) #6
Ian Swett
lgtm Thanks!
6 years, 3 months ago (2014-09-09 01:58:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/549343002/20001
6 years, 3 months ago (2014-09-09 02:05:18 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-09 02:05:20 UTC) #11
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-09 02:34:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/549343002/20001
6 years, 3 months ago (2014-09-09 02:37:09 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 66b3b79cabe1225822d8554d41a7fb1df58d0ffc
6 years, 3 months ago (2014-09-09 09:39:07 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36c907908a398eb2d483227891165937ad473e0e
Cr-Commit-Position: refs/heads/master@{#293908}

Powered by Google App Engine
This is Rietveld 408576698