Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: net/quic/quic_connection_logger.cc

Issue 549343002: Add various fields of the QUIC ack frame to net-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_logger.cc
diff --git a/net/quic/quic_connection_logger.cc b/net/quic/quic_connection_logger.cc
index 8157848fff62ff06eba358da203057cf82aa70b8..ae67e08ae0778faba0f735311a6b6c669a07c938 100644
--- a/net/quic/quic_connection_logger.cc
+++ b/net/quic/quic_connection_logger.cc
@@ -106,7 +106,12 @@ base::Value* NetLogQuicAckFrameCallback(const QuicAckFrame* frame,
base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetString("largest_observed",
base::Uint64ToString(frame->largest_observed));
+ dict->SetInteger("delta_time_largest_observed_us",
+ frame->delta_time_largest_observed.ToMicroseconds());
+ dict->SetInteger("entropy_hash",
+ frame->entropy_hash);
dict->SetBoolean("truncated", frame->is_truncated);
+
base::ListValue* missing = new base::ListValue();
dict->Set("missing_packets", missing);
const SequenceNumberSet& missing_packets = frame->missing_packets;
@@ -114,6 +119,26 @@ base::Value* NetLogQuicAckFrameCallback(const QuicAckFrame* frame,
it != missing_packets.end(); ++it) {
missing->AppendString(base::Uint64ToString(*it));
}
+
+ base::ListValue* revived = new base::ListValue();
+ dict->Set("revived_packets", revived);
+ const SequenceNumberSet& revived_packets = frame->revived_packets;
+ for (SequenceNumberSet::const_iterator it = revived_packets.begin();
+ it != revived_packets.end(); ++it) {
+ revived->AppendString(base::Uint64ToString(*it));
+ }
+
+ base::ListValue* received = new base::ListValue();
+ dict->Set("received_packet_times", received);
+ const PacketTimeList& received_times = frame->received_packet_times;
+ for (PacketTimeList::const_iterator it = received_times.begin();
+ it != received_times.end(); ++it) {
+ base::DictionaryValue* info = new base::DictionaryValue();
+ info->SetInteger("sequence_number", it->first);
+ info->SetInteger("received", it->second.ToDebuggingValue());
+ revived->Append(info);
+ }
+
return dict;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698