Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 54933002: Enable ActivityLogApiTest.TriggerEvent and update test (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
Reviewers:
felt, Matt Perry
CC:
karenlees, chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable ActivityLogApiTest.TriggerEvent and update test Blink rev has been rolled to r161048, which includes the innerHTML move from HTMLElement to Element. Update and enable the test that had to be disabled during the transition. BUG=311080 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233586

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/activity_log_private/test/test.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 17 (0 generated)
davve
7 years, 1 month ago (2013-10-31 15:49:32 UTC) #1
dglazkov
Matt, can you look at that?
7 years, 1 month ago (2013-10-31 16:52:53 UTC) #2
felt
https://codereview.chromium.org/54933002/diff/1/chrome/test/data/extensions/api_test/activity_log_private/test/test.js File chrome/test/data/extensions/api_test/activity_log_private/test/test.js (right): https://codereview.chromium.org/54933002/diff/1/chrome/test/data/extensions/api_test/activity_log_private/test/test.js#newcode275 chrome/test/data/extensions/api_test/activity_log_private/test/test.js:275: domExpectedActivity.push('HTMLElement.' + hookNames[i]); to double check, this ONLY impacts ...
7 years, 1 month ago (2013-10-31 17:32:17 UTC) #3
davve
https://codereview.chromium.org/54933002/diff/1/chrome/test/data/extensions/api_test/activity_log_private/test/test.js File chrome/test/data/extensions/api_test/activity_log_private/test/test.js (right): https://codereview.chromium.org/54933002/diff/1/chrome/test/data/extensions/api_test/activity_log_private/test/test.js#newcode275 chrome/test/data/extensions/api_test/activity_log_private/test/test.js:275: domExpectedActivity.push('HTMLElement.' + hookNames[i]); On 2013/10/31 17:32:18, felt wrote: > ...
7 years, 1 month ago (2013-10-31 19:03:10 UTC) #4
Matt Perry
lgtm
7 years, 1 month ago (2013-10-31 19:09:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54933002/1
7 years, 1 month ago (2013-10-31 19:44:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54933002/1
7 years, 1 month ago (2013-10-31 23:54:56 UTC) #7
commit-bot: I haz the power
Change committed as 232385
7 years, 1 month ago (2013-11-01 14:48:47 UTC) #8
csharp
On 2013/11/01 14:48:47, I haz the power (commit-bot) wrote: > Change committed as 232385 Reverted ...
7 years, 1 month ago (2013-11-01 20:13:20 UTC) #9
davve
On 2013/11/01 20:13:20, csharp wrote: > On 2013/11/01 14:48:47, I haz the power (commit-bot) wrote: ...
7 years, 1 month ago (2013-11-01 21:14:36 UTC) #10
felt
On 2013/11/01 21:14:36, davve wrote: > On 2013/11/01 20:13:20, csharp wrote: > > On 2013/11/01 ...
7 years, 1 month ago (2013-11-01 22:36:52 UTC) #11
davve
On 2013/11/01 22:36:52, felt wrote: > On 2013/11/01 21:14:36, davve wrote: > > Is there ...
7 years, 1 month ago (2013-11-03 12:38:27 UTC) #12
felt
On 2013/11/03 12:38:27, David Vest wrote: > On 2013/11/01 22:36:52, felt wrote: > > On ...
7 years, 1 month ago (2013-11-05 18:47:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54933002/1
7 years, 1 month ago (2013-11-05 18:51:18 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219944
7 years, 1 month ago (2013-11-05 22:39:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54933002/1
7 years, 1 month ago (2013-11-07 10:50:16 UTC) #16
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 11:59:32 UTC) #17
Message was sent while issue was closed.
Change committed as 233586

Powered by Google App Engine
This is Rietveld 408576698