chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc - Issue 54933002: Enable ActivityLogApiTest.TriggerEvent and update test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc

Issue 54933002: Enable ActivityLogApiTest.TriggerEvent and update test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/activity_log_private/test/test.js » ('j') | chrome/test/data/extensions/api_test/activity_log_private/test/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc

index 233565ecc2a89c33a536db7a53dc6fd99e227a46..9c1f7be574ac6c2487f8e89a8ccf919ce4e96d10 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc

@@ -50,9 +50,7 @@ class ActivityLogApiTest : public ExtensionApiTest {

// TODO(karenlees): fix flakiness on win debug - crbug.com/299393

#define MAYBE_TriggerEvent DISABLED_TriggerEvent

#else

-// Disabled while waiting for Blink roll to avoid

-// https://codereview.chromium.org/52203002

-#define MAYBE_TriggerEvent DISABLED_TriggerEvent

+#define MAYBE_TriggerEvent TriggerEvent

#endif

// The test extension sends a message to its 'friend'. The test completes