Link to stdio output for compile failures.

Tools/GardeningServer/ui/ct-results-detail.html

Index: Tools/GardeningServer/ui/ct-results-detail.html
diff --git a/Tools/GardeningServer/ui/ct-results-detail.html b/Tools/GardeningServer/ui/ct-results-detail.html
index 1eef8a14105f66eef37959de6cf394bc4356c3b5..318c4f19914abc269a5b97195b12732aac731d8e 100644
--- a/Tools/GardeningServer/ui/ct-results-detail.html
+++ b/Tools/GardeningServer/ui/ct-results-detail.html
@@ -46,6 +46,10 @@ found in the LICENSE file.
         builder: '_update',
       },
 
+      _isStdioStep: function(result, step) {

[ojan, 2014/09/11 18:09:08]

This is fine, especially since this code needs to move into a model class
anyways. The other thing you could do is to use an anonymous function scope
around the whole Polymer call. Either way is fine.

<script>
(function() {
  function isStdioStep(...) {
    ...
  }

  Polymer({...});
})();

+        return result.actual == 'UNKNOWN' || step == 'compile';
+      },
+
       _update: function() {
         if (!this.failure || !this.builder)
           return;
@@ -56,7 +60,7 @@ found in the LICENSE file.
 
         var result = this.failure.resultNodesByBuilder[this.builder];
         // FIXME: There's probably a less hacky way to check this.
-        if (result.actual == 'FAIL' || result.actual == 'UNKNOWN')
+        if (result.actual == 'FAIL' || this._isStdioStep(result, this.failure.step))
           this._updateUrls();
         else
           this._updateWebkitTestUrls();
@@ -94,7 +98,7 @@ found in the LICENSE file.
 
         // FIXME: We only store build logs by the test name, not the testsuite.testname,
         // which means that two failing tests from different test suites conflict!
-        var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testName.split('.')[1];
+        var testPart = this._isStdioStep(result, this.failure.step) ? 'stdio' : this.failure.testName.split('.')[1];
         var url = result.masterUrl +
             '/builders/' + encodeURIComponent(this.builder) +
             '/builds/' + result.lastFailingBuild +