Link to stdio output for compile failures.

Tools/GardeningServer/ui/ct-results-detail.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="ct-results-comparison.html">
 
 <polymer-element name="ct-results-detail" attributes="failure builder">
   <template>
@@ skipping 28 matching lines @@
       _kExpectedKind: results.kExpectedKind,
       _kActualKind: results.kActualKind,
       _kDiffKind: results.kDiffKind,
       _kUnknownKind: results.kUnknownKind,
 
       observe: {
         failure: '_update',
         builder: '_update',
       },
 
+      _isStdioStep: function(result, step) {

[ojan, 2014/09/11 18:09:08]

This is fine, especially since this code needs to move into a model class
anyways. The other thing you could do is to use an anonymous function scope
around the whole Polymer call. Either way is fine.

<script>
(function() {
  function isStdioStep(...) {
    ...
  }

  Polymer({...});
})();

+        return result.actual == 'UNKNOWN' || step == 'compile';
+      },
+
       _update: function() {
         if (!this.failure || !this.builder)
           return;
 
         // FIXME: If the types of groups doesn't change, then it'd be better to do this
         // update in place so that the user doesn't see a flicker.
         this._urlGroups = [];
 
         var result = this.failure.resultNodesByBuilder[this.builder];
         // FIXME: There's probably a less hacky way to check this.
-        if (result.actual == 'FAIL' || result.actual == 'UNKNOWN')
+        if (result.actual == 'FAIL' || this._isStdioStep(result, this.failure.step))
           this._updateUrls();
         else
           this._updateWebkitTestUrls();
       },
 
       _updateWebkitTestUrls: function() {
         var result = this.failure.resultNodesByBuilder[this.builder];
         var failureInfo = results.failureInfo(this.failure.testName, this.builder, result.actual);
 
         // FIXME: Move this logic to a proper model class so that the network requests this makes
@@ skipping 17 matching lines @@
       },
 
       _updateUrls: function() {
         // FIXME: Along with _updateWebkitTestUrls, move this logic to a proper model class
         // so that the network requests this makes can be easily mocked out in tests.
 
         var result = this.failure.resultNodesByBuilder[this.builder];
 
         // FIXME: We only store build logs by the test name, not the testsuite.testname,
         // which means that two failing tests from different test suites conflict!
-        var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testName.split('.')[1];
+        var testPart = this._isStdioStep(result, this.failure.step) ? 'stdio' : this.failure.testName.split('.')[1];
         var url = result.masterUrl +
             '/builders/' + encodeURIComponent(this.builder) +
             '/builds/' + result.lastFailingBuild +
             '/steps/' + this.failure.step +
             '/logs/' + testPart;
 
         var resultsUrlsByKind = {};
         resultsUrlsByKind[this._kUnknownKind] = url;
 
         this._urlGroups.push({
           type: results.kTextType,
           urls: resultsUrlsByKind,
         });
       },
     });
   </script>
 </polymer-element>