Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 549303003: Abort if BrowserMainLoops fails to start a browser thread (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Abort if BrowserMainLoops fails to start a browser thread BUG=390853 Committed: https://crrev.com/1762c8f9f6dd980da99bea1c3ab5f04201ab4884 Cr-Commit-Position: refs/heads/master@{#295501}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add a CHECK in UserInputMonitorLinux #

Patch Set 3 : LOG(FATAL) in BrowserMainLoop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/browser_main_loop.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 34 (10 generated)
jiayl
darin@, Could you take a look?
6 years, 3 months ago (2014-09-08 22:59:07 UTC) #2
jiayl
6 years, 3 months ago (2014-09-10 16:30:14 UTC) #4
jiayl
Charlie, Could you take a look?
6 years, 3 months ago (2014-09-10 16:30:32 UTC) #6
Charlie Reis
[+jam] This seems like it would just paper over a bigger problem. What would happen ...
6 years, 3 months ago (2014-09-10 17:34:23 UTC) #8
jiayl
On 2014/09/10 17:34:23, Charlie Reis wrote: > [+jam] > > This seems like it would ...
6 years, 3 months ago (2014-09-10 19:42:30 UTC) #9
Charlie Reis
On 2014/09/10 19:42:30, jiayl wrote: > On 2014/09/10 17:34:23, Charlie Reis wrote: > > [+jam] ...
6 years, 3 months ago (2014-09-10 23:24:31 UTC) #10
jiayl
On 2014/09/10 23:24:31, Charlie Reis wrote: > On 2014/09/10 19:42:30, jiayl wrote: > > On ...
6 years, 3 months ago (2014-09-10 23:48:03 UTC) #11
Charlie Reis
On 2014/09/10 23:48:03, jiayl wrote: > On 2014/09/10 23:24:31, Charlie Reis wrote: > > On ...
6 years, 3 months ago (2014-09-11 23:10:30 UTC) #12
jiayl
https://codereview.chromium.org/549303003/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/549303003/diff/1/content/browser/browser_main_loop.cc#newcode1049 content/browser/browser_main_loop.cc:1049: if (io_thread_->message_loop_proxy().get() != NULL && On 2014/09/11 23:10:30, Charlie ...
6 years, 3 months ago (2014-09-11 23:55:37 UTC) #13
jam
the check is useless. check how BrowserThreadsStarted is called. the IO thread must have been ...
6 years, 3 months ago (2014-09-12 04:21:47 UTC) #14
jiayl
On 2014/09/12 04:21:47, jam wrote: > the check is useless. check how BrowserThreadsStarted is called. ...
6 years, 3 months ago (2014-09-12 15:56:36 UTC) #15
jiayl
On 2014/09/12 15:56:36, jiayl wrote: > On 2014/09/12 04:21:47, jam wrote: > > the check ...
6 years, 3 months ago (2014-09-15 23:18:00 UTC) #16
jam
On 2014/09/15 23:18:00, jiayl wrote: > On 2014/09/12 15:56:36, jiayl wrote: > > On 2014/09/12 ...
6 years, 3 months ago (2014-09-17 16:50:26 UTC) #17
jiayl
tommi Please take a look. I think it may happen in the rare case that ...
6 years, 3 months ago (2014-09-17 18:53:38 UTC) #20
tommi (sloooow) - chröme
Is this to track down an issue on Android or only on Linux? From what ...
6 years, 3 months ago (2014-09-17 21:10:01 UTC) #21
jiayl
On 2014/09/17 21:10:01, tommi wrote: > Is this to track down an issue on Android ...
6 years, 3 months ago (2014-09-17 22:05:40 UTC) #22
tommi (sloooow) - chröme
What about listening to the WillDestroyCurrentMessageLoop event for the IO thread/loop and clear the pointer ...
6 years, 3 months ago (2014-09-17 22:09:25 UTC) #23
jiayl
On 2014/09/17 22:09:25, tommi wrote: > What about listening to the WillDestroyCurrentMessageLoop event for the ...
6 years, 3 months ago (2014-09-17 23:05:50 UTC) #24
tommi (sloooow) - chröme
OK, lgtm. If the pointer is NULL then that seems like an important thing to ...
6 years, 3 months ago (2014-09-18 07:26:29 UTC) #25
jiayl
Adding creis@ for owner's review, since I'm not sure if jam@ is available to take ...
6 years, 3 months ago (2014-09-18 16:51:16 UTC) #29
Charlie Reis
LGTM
6 years, 3 months ago (2014-09-18 17:13:20 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/549303003/40001
6 years, 3 months ago (2014-09-18 17:21:12 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 8eeef2aed447daeeda1114706450dadb4b06c36f
6 years, 3 months ago (2014-09-18 18:23:52 UTC) #33
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:24:28 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1762c8f9f6dd980da99bea1c3ab5f04201ab4884
Cr-Commit-Position: refs/heads/master@{#295501}

Powered by Google App Engine
This is Rietveld 408576698