Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: content/browser/browser_main_loop.cc

Issue 549303003: Abort if BrowserMainLoops fails to start a browser thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LOG(FATAL) in BrowserMainLoop Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index 2a34b24ef02542b39966e2ccab814cafb4a13b00..9cea42c2f302ac73ab2ee04168bd7744c77ea306 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -716,7 +716,9 @@ int BrowserMainLoop::CreateThreads() {
if (thread_to_start) {
(*thread_to_start).reset(new BrowserProcessSubThread(id));
- (*thread_to_start)->StartWithOptions(options);
+ if (!(*thread_to_start)->StartWithOptions(options)) {
+ LOG(FATAL) << "Failed to start the browser thread: id == " << id;
+ }
} else {
NOTREACHED();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698