Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 549273002: Various mojom cleanup from ContentHandler changes. (Closed)

Created:
6 years, 3 months ago by Aaron Boodman
Modified:
6 years, 3 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Various mojom cleanup from ContentHandler changes. Committed: https://crrev.com/9d091c28a8b6c3b8117462cb661a8c3967fb27e7 Cr-Commit-Position: refs/heads/master@{#294342}

Patch Set 1 #

Total comments: 2

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -326 lines) Patch
M mojo/examples/browser/browser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/examples/media_viewer/media_viewer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M mojo/mojo.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_examples.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 chunks +0 lines, -33 lines 0 comments Download
M mojo/services/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 chunk +1 line, -4 lines 0 comments Download
D mojo/services/launcher/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/services/launcher/launcher.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D mojo/services/public/interfaces/launcher/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/public/interfaces/launcher/launcher.mojom View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +2 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Aaron Boodman
6 years, 3 months ago (2014-09-08 20:58:49 UTC) #2
Matt Perry
lgtm with a question https://codereview.chromium.org/549273002/diff/1/mojo/services/public/interfaces/launcher/launcher.mojom File mojo/services/public/interfaces/launcher/launcher.mojom (left): https://codereview.chromium.org/549273002/diff/1/mojo/services/public/interfaces/launcher/launcher.mojom#oldcode1 mojo/services/public/interfaces/launcher/launcher.mojom:1: // Copyright 2014 The Chromium ...
6 years, 3 months ago (2014-09-08 21:06:57 UTC) #3
Aaron Boodman
https://codereview.chromium.org/549273002/diff/1/mojo/services/public/interfaces/launcher/launcher.mojom File mojo/services/public/interfaces/launcher/launcher.mojom (left): https://codereview.chromium.org/549273002/diff/1/mojo/services/public/interfaces/launcher/launcher.mojom#oldcode1 mojo/services/public/interfaces/launcher/launcher.mojom:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 3 months ago (2014-09-08 21:27:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/549273002/1
6 years, 3 months ago (2014-09-08 21:40:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/13495) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/13466)
6 years, 3 months ago (2014-09-09 02:20:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549273002/20001
6 years, 3 months ago (2014-09-11 05:52:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6e5bea3d579b1169e9817d4753a146b02d09fbc1
6 years, 3 months ago (2014-09-11 07:02:52 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 07:09:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d091c28a8b6c3b8117462cb661a8c3967fb27e7
Cr-Commit-Position: refs/heads/master@{#294342}

Powered by Google App Engine
This is Rietveld 408576698