Expose NavigatorHost via Embed() rather than globally.

Expose NavigatorHost via Embed() rather than globally.

BUG=

Committed: https://crrev.com/0073e99b9a5b0c2e78f8dd9a435c8b87763d2446
Cr-Commit-Position: refs/heads/master@{#293469}

[Aaron Boodman, 2014-09-04 08:02:58]

aa@chromium.org changed reviewers:
+ darin@chromium.org

[Aaron Boodman, 2014-09-04 08:02:59]

https://codereview.chromium.org/537843002/diff/20001/mojo/examples/media_view...
File mojo/examples/media_viewer/media_viewer.cc (left):

https://codereview.chromium.org/537843002/diff/20001/mojo/examples/media_view...
mojo/examples/media_viewer/media_viewer.cc:189: class NavigatorImpl : public
InterfaceImpl<Navigator> {
MediaViewer was already broken from previous changes, this just keeps it
compiling. It is a TODO to make it work again for real.

It's a slightly bigger project because it needs to change conceptually now that
we don't have a distinction between application and navigation URLs.

[Aaron Boodman, 2014-09-04 08:03:41]

Note that this change depends upon https://codereview.chromium.org/514063003/

[darin (slow to review), 2014-09-04 23:22:18]

LGTM

https://codereview.chromium.org/537843002/diff/20001/mojo/public/cpp/applicat...
File mojo/public/cpp/application/lazy_interface_ptr.h (right):

https://codereview.chromium.org/537843002/diff/20001/mojo/public/cpp/applicat...
mojo/public/cpp/application/lazy_interface_ptr.h:24: void
set_service_provider(ServiceProvider* service_provider) {
you probably want to make sure InterfacePtr<Interface>::get() would return null,
right? that way someone doesn't try to change the service provider after the
ConnectToService was called.

this method could also be called Initialize. not sure if you want to go there.
it might help re-inforce the idea that it can only be called once, and that it
is an alternative to the 1-arg ctor.

[Aaron Boodman, 2014-09-05 04:22:35]

https://codereview.chromium.org/537843002/diff/20001/mojo/public/cpp/applicat...
File mojo/public/cpp/application/lazy_interface_ptr.h (right):

https://codereview.chromium.org/537843002/diff/20001/mojo/public/cpp/applicat...
mojo/public/cpp/application/lazy_interface_ptr.h:24: void
set_service_provider(ServiceProvider* service_provider) {
On 2014/09/04 23:22:18, darin wrote:
> you probably want to make sure InterfacePtr<Interface>::get() would return
null,
> right? that way someone doesn't try to change the service provider after the
> ConnectToService was called.
> 
> this method could also be called Initialize. not sure if you want to go there.
> it might help re-inforce the idea that it can only be called once, and that it
> is an alternative to the 1-arg ctor.

I decided to just reset the InterfaceProvider when this is called, so that it
can be called multiple times. Does that work for you?

[darin (slow to review), 2014-09-05 04:26:55]

Yeah, that works. LGTM

[Aaron Boodman, 2014-09-05 05:40:59]

The CQ bit was checked by aa@chromium.org

[commit-bot: I haz the power, 2014-09-05 05:43:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aa@chromium.org/537843002/40001

[commit-bot: I haz the power, 2014-09-05 08:12:56]

Committed patchset #3 (id:40001) as a0edd9e4170913f73eda3d1f9de0ef7edbec758d

[commit-bot: I haz the power, 2014-09-10 03:37:46]

Patchset 3 (id:??) landed as
https://crrev.com/0073e99b9a5b0c2e78f8dd9a435c8b87763d2446
Cr-Commit-Position: refs/heads/master@{#293469}