Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 549243002: Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pageidipc
Project:
chromium
Visibility:
Public.

Description

Ensure that the browser’s copy of page id is in sync with the renderer’s. This has debugging statements in case it turns out not to be. Fingers crossed, though. BUG=407376 TEST=no crashing, we hope Committed: https://crrev.com/86823cbf672c0840146a93dc1d2217f01a9d6909 Cr-Commit-Position: refs/heads/master@{#294008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +24 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Avi (use Gerrit)
Robert, you know the drill. We get to see if the changes I made since ...
6 years, 3 months ago (2014-09-08 19:02:52 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-08 19:05:20 UTC) #3
Charlie Reis
Let's give it another try. LGTM.
6 years, 3 months ago (2014-09-08 19:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/549243002/1
6 years, 3 months ago (2014-09-08 20:36:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/549243002/1
6 years, 3 months ago (2014-09-09 12:34:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/11595)
6 years, 3 months ago (2014-09-09 13:14:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/549243002/1
6 years, 3 months ago (2014-09-09 19:09:13 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-09 21:11:07 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:36 UTC) #16
Patchset 1 (id:??) landed as
https://crrev.com/86823cbf672c0840146a93dc1d2217f01a9d6909
Cr-Commit-Position: refs/heads/master@{#294008}

Powered by Google App Engine
This is Rietveld 408576698